quotation mark not being changed when plugin wp-sort-order active

  • Resolved huegelkind

    (@mpzimmer)


    7 years, 9 months ago

    Hi,

    with wp-sort-order active the quotations marks won’t change. Adding “add_filter( ‘typo_ignore_parser_errors’, ‘__return_true’ );” to the functions.php of the active theme Catch Everest has no effect.

    Would be glad for some help or a recommendation for another “sort”-plugin that doesn’t interfere with wp-typography (btw, really great plugin, gonna love it!)

    Regards,

    Michael

    https://huegelkind.eu

    • This topic was modified 7 years, 9 months ago by huegelkind.
    • This topic was modified 7 years, 9 months ago by huegelkind.
Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author pepe

    (@pputzer)

    The problem is the premature call to get_plugin_data on line 21 of index.php in wp-sort-order – this means wptexturize is called very early, before wp-Typography’s filters are set up. I thought I had a fix for such inconsiderately written plugins, but apparently it’s not working. I’ll have look at my workaround, but the real fix would be to not call get_plugin_data with $markup set to true (by default) before the init hook.

    Basically, a fix should be applied in WP Sort Order. Either setting the parameter $markup to false or initializing the global when it is actually used should do the trick. (Better yet, would be getting rid of the global altogether.)

    Addendum: This issue has come up before, for example in Freemius. Also, the documentation for wptexturize notes that it should not be called before init, though get_plugin_data does not yet include a warning to the same effect.

    • This reply was modified 7 years, 9 months ago by pepe.
    • This reply was modified 7 years, 9 months ago by pepe.
    Plugin Author pepe

    (@pputzer)

    Found the reason why my workaround didn’t work. 4.0.2 should make WP Sort Order (and others) behave. However, the call to get_plugin_data should still be fixed there.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘quotation mark not being changed when plugin wp-sort-order active’ is closed to new replies.