Questions about product_block and request for full name notation.

  • Resolved Mizuho Ogino

    (@fishpie)


    10 months, 2 weeks ago

    I was wondering why the same numbers are output in the following two places in product_block. Sorry if my understanding is incorrect.

    class-cartflows-ca-tabs.php line 464 and 465
    class-cartflows-ca-email-schedule.php line 313 and 314
    If “Price” means “unit price”, then these lines should be $cart_item[‘data’]->get_price(), not $cart_item[‘line_total’].

    ——

    I am in the process of creating a pot-file for the Japanese translation, and in it I noticed that the following full name description is unnatural.
    In some languages, such as Japanese, the order of full name is not first name + last name, but last name + first name, and WooCommerce has a procedure for normalizing full names using translation files. I hope you will be able to handle this someday.

    Example description in WooCommerce:
    sprintf( _x( ‘%1$s %2$s’, ‘full name’, ‘woocommerce’ ), $first_name, $last_name );

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Support Sravan Bhaskaravajjula

    (@bhshravankumar)

    Hello @fishpie,

    The implementation that we have added in the WCAR is correct. The reason for this is we are fetching the data from the database which is stored when the user abandons the cart on the checkout page.

    So the code which is used to print the prices in the product table is correct as per the data that we store in the database.

    ——

    We understand that the natural order of full names in Japanese and some other languages differs from the first name + last name format. WooCommerce does provide a mechanism for normalizing full names using translation files.

    We acknowledge that this may not align with the natural order in all languages. This is an important consideration, and we will explore ways to address it in future updates to improve localization support.

    Thank you for bringing this to our attention.

      Thread Starter Mizuho Ogino

      (@fishpie)

      Thank you for your thoughtful response!!
      I understand about the specifications.

      ===========

      I am also very glad to hear that you will consider localization, I have updated GlotPress with the Japanese localization data and hope to see more users from Japan in the future.

      Plugin Support Aamir

      (@aamiribsf)

      Hello @fishpie,

      You’re most welcome!

      If you have more questions, please don’t hesitate to raise a new ticket! 

      Have a great day ahead ??

    Viewing 3 replies - 1 through 3 (of 3 total)
    • The topic ‘Questions about product_block and request for full name notation.’ is closed to new replies.

    Tags