Question(s) about no_robots fix in the lockout.php template file

  • Resolved nlpro

    (@nlpro)


    3 years, 11 months ago

    @timothybjacobs

    I noticed you fixed the core/templates/lockout/lockout.php file in the latest iTSec plugin 7.9.1 release for >= 5.7.x compatibility.

    I have 2 questions about that fix:

    1. The WordPress core _default_wp_die_handler() first adds:

    add_filter( 'wp_robots', 'wp_robots_no_robots' );

    … and then executes wp_robot().

    Would it not make sense to add the wp_robots filter to the core/templates/lockout/lockout.php file too ? (From a consistency as well as a functional point of view).

    2. I noticed you fixed the code with several seperate opening and closing PHP tags. Why not use a single opening and closing PHP tag? (Like in the WordPress core _default_wp_die_handler() callback). WordPress core coding standards ?

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Timothy Jacobs

    (@timothyblynjacobs)

    Hey @nlpro!

    1. That’s certainly a possibility. We’ll probably move to that once we drop 5.6 support.

    2. Yeah, that’s just a coding standards preference really. I don’t like to mix PHP templating syntax, with PHP logic syntax if that makes sense.

    Thread Starter nlpro

    (@nlpro)

    @timothyblynjacobs

    Thank you for your feedback.

    There is something else I bumped into recently. And I’m really interested in your opinion. I’ll create a new topic for it ??
    Closing this one.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Question(s) about no_robots fix in the lockout.php template file’ is closed to new replies.