pum-debug.log file with mulitple ‘deprecated’ messages

  • Resolved njwp

    (@njwp)


    6 years, 5 months ago

    Hi

    I recently installed popup maker and see that in the wp-content/uploads directory it has created a file called:
    pum-debug.log

    with multiple instances of this line:

    filter:popmake_get_the_popup_data_attr is deprecated since version 1.7.0! Use filter:pum_popup_data_attr instead

    From looking at the code it seems you have a file called pum-deprecated-v1.7.php with this function:

    pum_deprecated_get_the_popup_data_attr_filter

    which is obviously designed to deal with deprecated instances of the popmake_get_the_popup_data_attr filter.

    It is logging the fact using:
    PUM_Logging::instance()->log_deprecated_notice( 'filter:popmake_get_the_popup_data_attr', '1.7.0', 'filter:pum_popup_data_attr' );

    Can we disable the logging so that the logfile doesn’t get stupidly large?

    Obviously I can edit your pum-deprecated-v1.7.php file, but that will get overwritten with the next update

    Note that if you Google “pum-debug.log” you get a list of sites with the same problem.

    Thanks

    • This topic was modified 6 years, 5 months ago by njwp.
Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Daniel Iser

    (@danieliser)

    @njwp – We recently (last Friday or so) became aware of this issue as a possibility. We are working to automatically clear that file as needed in a future update.

    That said can you tell me what extensions you have installed? Likely one of them needs an update, that said from my local codebase none of them still use that filter so likely you just need to update extensions.

    Hope that helps.

    Thread Starter njwp

    (@njwp)

    Thanks for the reply.

    When you say extensions – I assume you mean extensions for Popup Maker?
    I don’t have any of those extensions installed.

    Looking at your code, in:
    easy-modal-v2.php

    you have:
    function popmake_emodal_init()
    with this line
    add_filter( 'popmake_get_the_popup_data_attr', 'popmake_emodal_get_the_popup_data_attr', 10, 2 );

    and you are initialising that function:

    add_action( 'init', 'popmake_emodal_init' );

    It looks as though this should only trigger if you have the ‘Enable Easy Modal v2 Compatibility Mode ‘ option checked in settings.

    I don’t have that option checked, so that shouldn’t be firing – but maybe it is?

    I have done a search through my whole plugin codebase, and that is the only place in your code calling that function that I can see.

    • This reply was modified 6 years, 5 months ago by njwp.
    • This reply was modified 6 years, 5 months ago by njwp.
    Plugin Author Daniel Iser

    (@danieliser)

    @njwp – Will check into that file, but I just patched the core plugin to truncate that log file if its too large and only log each deprecated message once to keep them clean.

    v1.7.30 will include that when it goes out.

    Thread Starter njwp

    (@njwp)

    great – perfect solution, Thanks for the quick response.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘pum-debug.log file with mulitple ‘deprecated’ messages’ is closed to new replies.