pum-close popmake-close not working as expected

Hi @loumj84

Thank you for writing in and we are glad to help you sort the issue.

I checked the page where the issue is occurring. Indeed, the popup closes but it doesn’t go to the selected link as seen here https://share.getcloudapp.com/z8u11y6v
It did not change to use the URL yourdomain.com/en/qr-info/99080-mono-womens-shell-jacket/ when selecting the English link.

Upon checking the HTML code, it appears it is missing a “target=”_blank”” on the anchor link. Like what the example has in the article Close a Popup When a Link Inside the Popup Is Clicked.
Please see: https://share.getcloudapp.com/Kou77g4J

I suggest adding the target=”_blank” on the anchor link or link for the Dansk and English text.

On the other hand, you may remove the popmake-close pum-close do-default on the parent ul and include it on the anchor tags.

Please see: https://share.getcloudapp.com/2NuPPGOE
The anchor HTML would display like this
<a lang="da-DK" hreflang="da-DK" class="pum-close popmake-close do-default" href="URL"><img src="image URL" alt="Dansk" width="16" height="11" style="width: 16px; height: 11px;"><span style="margin-left:0.3em;">Dansk</span></a>

I hope that helps.

Let us know if the provided solution fixes the issue or if you have any questions.

Hey @loumj84,

Just to follow up, we found out that adding the do-default class to the link doesn’t always open the link.

The workaround is to add the data-do-default="true" attribute to your link instead. We’ve updated our documentation. Please check it out to see a full code example.

https://docs.wppopupmaker.com/article/303-close-a-popup-when-a-link-inside-the-popup-is-clicked#text-targeted-as-a-link

Remember to add this to your link tag, not your ul tag as @belimperial said earlier.

Cheers!

• This reply was modified 3 years, 4 months ago by mark l chaves.

Hi there
Thank you so much for your help. I applied both of your suggestions and it worked!

So I went ahead and installed everything on my live site, only to discover a new problem I didn’t have on my staging site:

The page the popup is applied to freezes, that is, the popup is not visible and it is not possible to scroll.

You can see the effect on this page only:
https://xplor.dk/qr-info/99084-mono-dame-skalparka/?pum_debug

In the debug it looks like it should work. But it’s not.

Any suggestions?

Thanks again for your help!

Hey @loumj84,

Great. Thanks for the follow-up.

The page the popup is applied to freezes, that is, the popup is not visible and it is not possible to scroll.

That’s probably from a CSS conflict.

Please see our “Your Popup Is Not Displaying on Your Homepage (or Another Page)” guide.

https://docs.wppopupmaker.com/article/544-your-popup-is-not-displaying-on-your-homepage#targeting

The debug parameter should be ?pum_debug=true.

Also, to remove the accessibility border that displays on your popup, please apply this CSS.

https://gist.github.com/marklchaves/12ffe01c4aadf938caa23b4f0ca33681

We’ll add that CSS as a permanent fix in the next release. Sorry for the inconvenience.

Or if it’s easier, you can temporarily disable the accessiblity features for each popup under Popup Settings > Advanced.

https://jmp.sh/JSGw6G1

Let us know if you need anything else.

Have a great day ??

Hey @mlchaves
The css trick fixed it! Thank you so much for your help

Great day to you too!

Hi there @loumj84 – on behalf of my colleagues, you are most welcome and we’re glad to hear that it worked for you. ??

By the way, if you have time then we would very much appreciate it if you could quickly rate the plugin, just to help us spread the word.

Have a great day! Cheers