Profile image uploads / set URL display broken images

I found a way to get the images to display but it’s a bit ‘wonky’. I had to move the image from the media files location in WordPress to the images directory in the plugin itself.

Hi ecmac,

Sorry I didn’t answer this sooner. It sounds like the internal code isn’t picking up the right file location for displaying the image.

… and it looks like I can duplicate the issue on my test site (I’m sure I’d tested this function properly… but oh well).

I’ll aim to get this fixed in the next version. Thanks for your bug report.

Thanks,

Magent

p.s. out of curiosity, would you mind linking me to the site you are using it on? It would be cool/useful to see where else the plugin is being used apart from the 2 larps I’m involved with.

Absolutely! We’re using it for a tabletop game locally that meets once a month and allowing our friends who are out of the area to play NPCs via the blog features.

https://northofmidnight.org

Thank you as well and no worries!

By the way, is this the best place for me to submit any issues I might find? There was one other thing but I squarely proved it being an issue with our host by trying to replicate on my demo site hosted on another server/hosting service and fixed it on the production site.

Thanks for the link ??

Yes, this is the best place to post issues. It’s the first place other users are likely to look if they also have a problem and now that I know that gmail is filing the emails with the post notifications under ‘Social’ I won’t miss posts.

I worked out the issue with the profile images today and have coded a fix so it’ll definitely be in the next version. If you are confident editing PHP (which I suspect you are) I can post the change?

If you want to see the other features/bug fixes I’m working on, the current issue list is on https://plugin.gvlarp.com

That would be great if you could post the fix; thanks in advance.

Also thanks much for the list of features/fixes. I see that on the list is setting the primary Thaumaturgy path for a character. Can this also apply to Necromancy paths?

Thanks again,
emac

In the file: inc/portrait_image.php

Remove lines:

               elseif(!file_exists($file)) {
                       $file = VTM_PLUGIN_URL . "/$file";
                       //if(!file_exists($file)) {
                       //      echo "<p>Problem finding file: $file</p>";
                       //}

And replace with:

               elseif (filter_var($file, FILTER_VALIDATE_URL) === FALSE) {
                       if(!file_exists($file)) {
                               $file = VTM_PLUGIN_URL . "/$file";
                               if(!file_exists($file)) {
                                       echo "<p>Problem finding file: $file</p>";
                               }
                       }
                }

Yes, the change will also apply to necromancy paths. In the character generation templates, you’ll be able to set which is the default path for each discipline (and vary that according to clan, if you want). You’ll also be able to set if you want to allow players to change the default path during character generation.

It’s a pretty complicated function so it’ll take a while before it’s ready. It’ll definitely be in the next version. I played a Tremere relatively recently so it was bugging me how the Primary path doesn’t really match the rules. ??