Problems with tickets soldout & shared tickets

Hi,

I had an event that was marked as sold out, while it still had one ticket left. In researching the problem, I found there was a shared ticket capacity in the ticket options set to -1 and the function that marks tickets as sold out adds the shared ticket capacity to the ticket count after it has processed the actual tickets.

Diving in the program, I found the global ticket meta was set for that event and the amount of -1 made it be marked as sold out. Since I don’t use shared tickets and there were no tickets with that setting, it took me a lot of time to find. Normally I have no reason to even look in the tickets config.

There are some obvious problems with this functionality:

1. It is possible to save negative numbers in the shared ticket capacity
2. It is counted even when there are no tickets that use the shared capacity, or the full capacity
3. How is the shared tickets option (or global tickets as it seems to be called in the source code) removed or set to false for an event after it is accidently set to true?
4. The shared capacity is rather hidden in the ticket meta-panel in the events admin. It isn’t even counted in the Total Event Capacity, even though it is still used to determine whether an event is soldout and there is no indication it isn’t used.

A solution of this bug would probably include some of this:

1. Don’t allow negative numbers in the shared capacity in the tickets config
2. Check for tickets that actually use the shared capacity before counting it in the total number of (available) tickets, and take account of the ticket caps in doing that.
3. Make unused shared capacity more visible in the ticket metabox in the events admin, and report it explicitly as unused shared capacity when there are no tickets using it, or something like that.
4. make the sold out functionality and the ticket count more accurate like this

Thanks.

regards, Hans