problems with link parameters in markup templates

  • Resolved wesm

    (@wesm)


    6 years ago

    I want to get inside the img tag generated for each image in a gallery. I have tried using the link, link_url, and friends parameters in my markup template. The first problem is that the link substitution parameter generates the entire < a> tag with the img tag embedded. OK, So I was expecting the link_url parameter to give me the actual href part. However, this doesn’t work if I call the mla_gallery shortcode with a different mla_link_href argument, which itself contains a computed value based on a custom field;

    I get [+query:mla_link_href+] generating
    mla_link_href: /galleries/rml-content/{+custom:last_gallery_slug+}
    when I call the shortcode with the same value.

    Could we at least get link_url to point to the right thing?

    • This topic was modified 6 years ago by wesm.
    • This topic was modified 6 years ago by wesm.
Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author David Lingren

    (@dglingren)

    Thanks for your report. You wrote “I want to get inside the img tag…“, but the substitution parameters you mentioned are for the hyperlink that surrounds the image tag, not the image tag itself; is that right?

    I agree that the link_url substitution parameter should reflect any changes introduced by the mla_link_href shortcode parameter. I will correct this MLA defect, release a new Development Version with the fix and post an update here when the new version is available. Thanks for bringing this defect to my attention.

    Is there anything else about the img tag itself that I should look into?

    Plugin Author David Lingren

    (@dglingren)

    I have uploaded a new MLA Development Version dated 20190306 that contains a fix for the issue you reported. You can find step-by-step instructions for using the Development Version in this earlier topic:

    PHP Warning on media upload with Polylang

    It would be great if you can install the Development Version and let me know if it works for you. I will leave this topic unresolved until I hear back from you. Thanks again for alerting me to this MLA defect.

    Plugin Author David Lingren

    (@dglingren)

    I have released MLA version 2.79, which contains the fix for your issue.

    I am marking this topic resolved, but please update it if you have any trouble with the new version. Thanks again for your help with this MLA improvement.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘problems with link parameters in markup templates’ is closed to new replies.