• Resolved Square Eye

    (@squareeye)


    Hi, we updated a few sites using WP Forge to the latest version and the layout broke down on all of them: layout widths, menus, colours etc. Rolling back to 5.0.3 (I think) in each case solved it. Not sure if it’s the way we’ve used it or something – if you’d like to discuss privately we can supply more detail! Thanks for your work which is really appreciated.

Viewing 11 replies - 1 through 11 (of 11 total)
  • I have experienced the same thing. If you hear anything about how to easily fix this, please let us know!

    Theme Author ThemeAWESOME

    (@tsquez)

    You are very welcome. I will be updating the Github repository with the latest version. This will allow you to view what was changed.

    You can then adjust accordingly.

    Thread Starter Square Eye

    (@squareeye)

    Thanks very much tsquez, I’ll take a look. I started comparing two versions of one of our sites, one with 5.0.3 and one with 5.5.1.7. I think they must use different versions of Foundation and something has changed there, because on 5.0.3 I can see this (very important, I think) CSS rule in foundation.css:

    .row { max-width: 62.5rem; }

    But on 5.5.1.7 it’s not there any more – that seems to be causing the biggest issue with our layout breaking. Hope that’s helpful to others.

    Theme Author ThemeAWESOME

    (@tsquez)

    .row { max-width: 62.5rem; } has not been used for a very long time in WP-Forge. I took this out many versions ago when I added the ability for the end user to change the width of their theme via the customizer. Essentially I just removed the max-width value and just used the width value.

    If you look at the customizer, for example the header section, inside this area is a section called Header Content. Click on this and you will see the option for you to change the background color of this section as well as set the width.

    There are 5 sections within WP-Forge and they are: header section, navigation section, content section, footer sidebar section and footer section.

    Each one of these sections is inside of a container. These containers are set to a width and max-width of 100%. This is set

    Inside of these containers are the wrappers. These wrappers hold each section. Each section has a max-width of 64rem and the rows inside have a width of 100%.

    This allows the end user to set the width of each section.

    Thread Starter Square Eye

    (@squareeye)

    Thanks again Tsquez, that’s really helpful. I think we missed a few updates along the way but your improvements make perfect sense!

    For the record, here’s what I’ve added to the child theme stylesheet to make our site (the one I’m using as a test case) look nice again with 5.5.1.7:

    .row { max-width: 62.5rem;  background: #FFF; }
    #header { padding: 0; }

    Also, the main sidebar widgets disappeared, I think because at some stage the ID of “Main sidebar” was changed from “sidebar-1” to “main-sidebar” – so I changed the reference to it in sidebar.php of the child theme and it showed up again.

    Finally I also went into Appearance > Customize and:

    * In Header Section > Site title & tagline, unchecked the “Display Header Text” box
    * In Colors > Top-Bar Colors, set the main colour, because it was set to #333 and over-riding our child theme style for menu buttons
    * Also set some sidebar link colours that had changed with the upgrade
    * NB These are just issues I noticed but presumably I should go through all the settings in the Customizer and make sure they match the site branding etc

    I think that means we can stick with 5.5.1.7 and future versions now. Thanks for the steer on where to look.

    I am also having serious issues on all of my sites I had built on wpforge childthemes. Not too happy about the latest update, as I need to implement fixes on all the old sites…
    as soon as I have localised how the update broke my layouts, I will summarize it here.

    Theme Author ThemeAWESOME

    (@tsquez)

    That would be great. I am sure that it may help others who may be having similar issues.

    The versions of WP-Forge that were available “before” being hosted on www.remarpro.com contained many items that were not allowed due to WordPress Standards and these needed to be changed. Which they were.

    I did my best to maintain the original and again I apologize for any inconvenience this may have caused with updates.

    I also had loads of conflicts updating WP-Forge.

    Lots of Customizer options were added to the theme, and these were overriding child theme styles. I found it was easier to just remove the customizer styles all together:

    function remove_customizer() {
    remove_action( ‘wp_head’, ‘wpforge_customize_css’, 100);
    }
    add_action( ‘after_setup_theme’, ‘remove_customizer’ );

    I also noticed that functions-js got renamed to wpforge_fuctions, so if you’re using WP-Starter as a child theme, be sure to update your functions.php file. And you’ll need to manually load Font Awesome if you were using that.

    Theme Author ThemeAWESOME

    (@tsquez)

    I think that one thing everyone is forgetting is that, the theme review team dictates what is WordPress standards and that every theme has to follow those standards.

    For example, everything has to be prefixed with the name of the theme. This is why functions-js was changed to wpforge_functions.

    Hmmm, wonder how many times this topic is going to be rehased and also how many times I am going to have to apologize.

    Thread Starter Square Eye

    (@squareeye)

    Tsquez, as the original poster, can I make it very clear I wasn’t blaming you for anything or expecting an apology! I just wanted to report an issue, and subsequently to report some steps we’d taken in case they were helpful to anyone else in the same situation. Personally, I totally understand your need to evolve the theme and change things – and I’m a grateful user of a theme you provide for free! Apologies if my tone came across any differently…

    Theme Author ThemeAWESOME

    (@tsquez)

    No worries @squareeye,

    It is not/was not your tone. It just gets a little tiring hearing the same thing over and over again. Especially when WP-Forge is already into her second iteration after being hosted on WP.org.

    5.5.1.9 is coming soon ??

Viewing 11 replies - 1 through 11 (of 11 total)
  • The topic ‘Problem with update to 5.5.1.7’ is closed to new replies.