Problem with get_recipient() verification

  • Hey!

    Just wanted to let you know that after Woo update my WordPress is giving me a warning:
    Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in?/public_html/app/plugins/woocommerce/includes/emails/class-wc-email.php?on line?465

    It’s caused by the woocos-email.php file, exactly by this fragment:

    // Check if email should be sent to customer or to custom recipient
    if($this->get_recipient() !== '') {
    $this->recipient = $this->get_recipient();
    } else {
    $this->customer_email = true;
    }

    It would be nice to grab some update, thanks!

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author tychesoftwares

    (@tychesoftwares)

    Hi @schizoos,

    Thank you for letting us know about the warning! This issue originates from the WooCommerce core file (class-wc-email.php). It appears this isn’t caused by our plugin but rather by WooCommerce itself.

    To confirm that our plugin isn’t contributing to the issue, could you please deactivate our plugin temporarily and check if the warning still occurs?

    Let me know the result.

    Thread Starter schizoos

    (@schizoos)

    No, the warning doesn’t display when your plugin is deactivated.

    The problem is definitely with your plugin, as you’re doing verification by checking if($this->get_recipient() !== ''), so you’re calling get_recipient() function, passing it with no parameters (empty). I believe it would be much easier for you to rework it, then asking WC authors to make it work according to logic of your plugin :).

    Plugin Author tychesoftwares

    (@tychesoftwares)

    Hi @schizoos,

    Thank you for your patience and for sharing the details. We understand that the issue is coming from our plugin due to the way verification is handled.

    We have added this to our GitHub repository and will be working on a fix. We’ll keep you posted.

    Let us know if you have any further concerns in the meantime.

Viewing 3 replies - 1 through 3 (of 3 total)
  • You must be logged in to reply to this topic.