Problem With Firefox Users

Hi Kyle,
I tested out the version on Github and it works for both Firefox and Edge.
I think this is the fix. That is awesome Kyle!

Hi Kyle,

I just wanted to update this issue here. I am still using the development version on GitHub that you posted, while it works better (the play button just stays about a couple of seconds too long but better than staying all the way through the whole video) I was doing some testing with another site and I think I might have found the issue.

On the testing site I used your released version and also the development version on GitHub. It looks like the plugin has a conflict with Cloudflare CDN and a particular feature called “Rocket Loader”. When disabling “Rocket Loader” the plugin both the released version and the development version worked with no issues.
I would really hate disabling the “Rocket Loader” feature on Cloudflare, it does help in a big way on loading times on the site.

Cloudflare does have a manual setting that can be implemented for this plugin but I am not sure how to go about it, specially when the plugin requires future updates via new releases in the future, If you have any suggestions let me know.

Cloudflare suggestion is to add the following attribute to the HTML script tag before the ‘src’ attribute (adding the attribute via JavaScript is not sufficient) the following:

data-cfasync=“false”

It would be great that if in your next release you could incorporate this feature under settings, maybe something along the lines of “Cloudflare Compatibility Rocket Loader”.

Please also let me know if you get to implement this on the development version on GitHub or if you have any advice for me on how to go about using the data-cfasync=“false”.

Regards,

Lechon

I knew you were using Rocket Loader, and I use it on my own site as well, but while Rocket Loader’s asynchronous JavaScript loading and improved caching might be the instigator on your site, I’ve been able to reproduce this bug without Rocket Loader and even if you disable Rocket Loader you might see it happen again if the right local caching conditions happen to be met. The problem is not inherent to Rocket Loader, but Rocket Loader helps create the specific condition necessary for this bug to appear, which is that the native video player loads and begins playing before the Video.js script loads and takes over the player. When that happens, Video.js doesn’t get the message that the video has started and remains in “not started yet” mode. Unfortunately the developers at Video.js have not responded to me about this problem. I was holding out hope that their new 6.0 release would solve it, but it doesn’t.

I don’t see disabling Rocket Loader as a universal fix and the gymnastics necessary to get a data attribute into a script enqueued the proper way in WordPress are not something I’m willing to do for this edge case. If you do want to disable it on Cloudflare yourself, you can create a Page Rule to turn off Rocket Loader for specific scripts. I’m not sure which ones you should disable, but you could start with a wildcard URL like https://www.yourdomain.com/wp-content/plugins/video-embed-thumbnail-generator* which should disable RocketLoader for all scripts related to my plugin and all future releases of the plugin.

Hi Kyle,

Thanks for taking the time to explain this to me, it makes total sense.

I think I am going to wait until you release a version that fixes this issue, in the meantime I will be using the version your have on development mode for now.