Pricing NOT showing on shop catalog page

Please check out our new version of plugin a lot of bugs are resolved.

No, this bug still exists.

The problem is:
The user has no “country” cookie when visiting the site for the very first time.
The site is then displayed with the prices set in the “Regular Price” field from WC (not the localized price), because the request was done without cookies.
In the footer, the footerscript then sets a country by the google API.
And on the next reload, everything works as expected because there is a cookie.

Simple reproduction:

1. activate wp_debug in the wp-config.php
2. visit a page with items (shop-startpage or singlepage)
3. Then in the console or other way, clear your cookies for this domain.
4. Now Press F5.
5. The plugin will throw a lot of errors “unidentified index: ‘country'”.
6. Press F5 again.
7. The correct localized prices will show up.

You cannot set a request cookie with PHP, even with the setcookie() function. If you do set this with setcookie(), it will work on the next request of the page, but not on the current request.

My solution so far is to replace all $_COOKIE[‘country’] to $_SESSION[‘country’] and set the country in the init() function of woocommerce-price-by-country.php. Also I deactivate the country assignment via the javascript because I have a static PHP class which does that for me.
Also, I find it a bit weird to set a country AFTER rendering the shop items.. this is just failure by design ??

Email me at murphdotviennaatgmaildotcom if you have further questions.

Ok include your code in next relase

I think I’m having the same problem as this, was a fix put in? I’ve submit a separate support post but I think this might be the problem. I’ve checked the PHP file and the $_COOKIE[‘country’] is still there and not replaced with $_SESSION[‘country’].

The problem I’m having is that the VAT % is not being assigned to the country assigned ex-VAT price.

OK the fix is quite easy. No need to pass things around in the session.

All the $_COOKIE[‘country’] lookups should be replaced by a function which covers the case if no cookie is set.

function get_country_alt() {
    if (isset($_COOKIE) && isset($_COOKIE['country']) && !empty($_COOKIE['country'])) {
        # user has set a cookie - use its value
        return $_COOKIE['country'];
    } else {
        # do a country lookup by GeoIP, cURL, or just set a default value.
        $country = 'DE';

        # then set this country as a cookie directly with PHP.
        # the cookie will be valid from next request on.
        setcookie('country', $country, time()+86400, '/');
        return $country;
    }
}

Hope this helps.

With the $_COOKIE[‘country’] lookups I meant:

This code in the plugin repeats many times:

if (isset($_COOKIE['country'])) {
    $country = $_COOKIE['country'];
} else {
    $country = "";
}

Replace each of those blocks by:

$country = get_country_alt();

I’m really sorry about all this but it’s my first Woocommerce site, it looks like I have the functions.php file working, it’s showing the prices without the VAT from my products settings but when I replace the

if (isset($_COOKIE['country'])) {
    $country = $_COOKIE['country'];
} else {
    $country = "";
}

with

$country = get_country_alt();

to get the VAT applied all I’m getting is a blank white page? Any ideas?

Yeah, I just looked up the code on the shop server.
I remember again why we need the session.

Setting a cookie makes it valid from the NEXT request on,
if you are inside a loop, the cookie is not available immediately after setting it. This is a different behaviour compared to javascript.

function get_country_alt() {

    if (isset($_COOKIE) && isset($_COOKIE['country']) && !empty($_COOKIE['country'])) {

        # user has set a cookie - use its value
        return $_COOKIE['country'];

    } else if (isset($_SESSION['country'])) {

        # we just added the cookie but it will be active in the next request.
        # not checking this case leads to an infinite loop / white page.
        return $_SESSION['country'];

    } else if (!isset($_SESSION['country'])) {

        # user has no cookie AND has no session ==> first-time visit.
        # do a country lookup by GeoIP, cURL, or just set a default value.

        $country = 'DE';
        $_SESSION['country'] = $country;

        # then set this country as a cookie directly with PHP.
        # the cookie will be valid from next request on.
        # BUT, if already some headers were sent, we have to set the cookie with javascript (by the add_action hook) and use the stored $_SESSION variable until the next url request.

        if (!headers_sent()) {
            setcookie("country", $country, time() + 86400, '/');
        } else {
            add_action(	'wp_footer', 'wpbc_cookie_set_dom' , 1001);
        }

        return $country;
    }
}

# this action is needed in case headers were already sent.
function wpbc_cookie_set_dom()
{
    $country = $_SESSION['country'];
    echo '<script>
        x = new Date; x.setHours(36); x.toGMTString();
        document.cookie="country='.$country.'; expires= " + x + ";path=/"
    </script>';
}

Should work now..

Dear murphvienna
can you help me for my problem, please

the prices not show directly i must refresh
can you help me for that ?
thanks