Preparing Master Picture…never gets past this step

Sorry for the bad experience.

Could you tell me which browser are you using and which version? Also, can you know if some JavaScript issue happens in the background? For example, if you use Chrome, you can open the console with Ctrl+Shift+J. Then, any JavaScript issue will be reported in the console.

Also, could you tell me the URL of your picture? (ie. what is in the “Master picture” field) If you don’t want to disclose this here, you can also send it to me at [email protected]

Whatever your answer, just to let you know that I’m going to implement a workaround for such issue. Even if an error happen at this level, that should not block the process as it currently does on your side.

I had this error too.. Just went to the site button first and then upload the image there.
Using Chrome browser.

Hum… that’s frustrating! I’m definitely going to implement this workaround.

Just in case: did you have the opportunity to look at JavaScript errors? (easy if you’re familiar with JS development. Else… well, it’s complicated ?? )

Same problem, here is the JavaScript error that I see with it:

Uncaught SecurityError: Failed to execute ‘toDataURL’ on ‘HTMLCanvasElement’: Tainted canvases may not be exported.

Ah! This is a good clue. Thank you very much for reporting this. That’s right, this error was not handled. I was too concerned by the image loading itself, not thinking about canvas manipulations.

I would like to reproduce the issue to make sure the fix is effective. Can you give me:
– The browser you use
– The URL of your picture (ie. the content of your “Master picture URL” field in Appearance > Favicon). This may be private information, for example if your blog is still under development. So I’ll understand if your don’t want to disclose it here. If you want to share it privately, you can mail it to me at [email protected].

This issue was fixed in v1.2.11, released a minute ago.

I was never able to reproduce the issue. Could you give it another try and tell me if that works?

This feature was designed to pass a master picture from a WP site under development to RealFaviconGenerator. By “under development”, I mean a WP site that is only accessible by his admin. For example, my WP sandbox is only accessible through 192.168.1.93/wordpress, which is local. So RFG cannot download anything from my blog but my browser can. But that can cause security issues (what you reported, atsepkov).

So I did two things:
– I tried to catch this SecurityError, in order to fail gracefully.
– Since this is the kind of error some browsers may not let you catch (it sounds a bit “fatal”), I also implemented a timeout: if, after 3 seconds, the picture cannot be retrieved, this is certainly the sign that the feature won’t work anyway. The button is enabled again.

Did you have the opportunity to retry?

I’m confident the fix works, so if I have no news in the next few days I’ll close this ticket.

No news is good news! I close this issue. If you have the opportunity to test the fix and notice something wrong, don’t hesitate to open it again.

Thank you again for your feedback! It really helped me spot and fix this bug.