Preloader html outside body tag

  • Resolved Ov3rfly

    (@ov3rfly)


    1 year, 5 months ago

    Preloader html is added outside of body tag and causes error in html validation, also visible e.g. in Firefox “view source” Ctrl-u.

    Problem is in header.php

    	<?php wp_head(); ?>
</head>
<?php if($show_preloader){ ?>
<div class="page-loading"> <!-- #site-wrapper -->
  <div class="loader"></div>
  <span class="text">Loading...</span>
</div> <!-- .page-loading ends -->
<?php  } ?>

<body <?php body_class(); ?>>

    Suggested fix: Move code inside body tag.

    lawyerfirm 1.0.4, WordPress 6.3.2

Viewing 5 replies - 1 through 5 (of 5 total)
  • Thread Starter Ov3rfly

    (@ov3rfly)

    Found also another html problem, it appears that closing tag of <div class="main-wrap"> is missing at end of header.php.

    Thread Starter Ov3rfly

    (@ov3rfly)

    Another small bug is in 404.php where <div class="col-md-8"> should be <div class="col-md-12"> because there is no sidebar.

    Thread Starter Ov3rfly

    (@ov3rfly)

    Sinde 1.0.6 preloader html in header.php is added outside of body tag and inside of body tag:

    	<?php wp_head(); ?>
</head>
<?php if($show_preloader){ ?>
<div class="page-loading"> <!-- #site-wrapper -->
  <div class="loader"></div>
  <span class="text">Loading...</span>
</div> <!-- .page-loading ends -->
<?php  } ?>

<body <?php body_class(); ?>>
<?php if($show_preloader){ ?>
<div class="page-loading"> <!-- #site-wrapper -->
  <div class="loader"></div>
  <span class="text">Loading...</span>
</div> <!-- .page-loading ends -->
<?php  } ?>
<?php wp_body_open(); ?>
<div id="page" class="site">

    Suggested fix: Remove duplicate outside of body tag.

    The other two above mentioned bugs are not fixed yet.

    lawyerfirm 1.0.6, WordPress 6.4.3

    Theme Author flawlesstheme

    (@flawlesstheme)

    Hi,

    Thank you for reporting the issues. The Pre-loader issue is resolved and deployed. The team is checking on other issues and will act soon.

    Thread Starter Ov3rfly

    (@ov3rfly)

    Above mentioned issues are now fixed with lawyerfirm 1.0.8

    Cosmetic issue: Changelog in file readme.txt is incomplete.

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Preloader html outside body tag’ is closed to new replies.