Possible plugin conflicts

I guess these plugins are changing the setup so that you run in debug mode, is this possible?

I see similar errors in my test domain in debug mode, and I want to eliminate them for the next release, but haven’t seen any impact on real operation.

On the actual web server debug mode is off, but on my development server I always have it on. The operation of those plugins is simply where I’ve noticed the problem.

I also haven’t noticed any real impact from it, I just wanted to be certain. As it’s a known issue I’ll just wait for an update.

Thanks
Paul

As said, I try to get rid of them for the next release

Ok, these are harmless messages and I have fixed that problem in the git version. Next release will contain the fixes.

I’ve been using CGMP for some time now and I am glad to see someone has taken up the plugin’s development – thanks and well done Norbert.

Just wondering whether the update to fix this issue has been released?

I’ve just installed the plugin ver 0.2 and on activation, I get ‘PHP Notice: Use of undefined constant…’ in my php error log for the constants:

SGMP_DB_GEOMASHUP_DATA_CACHE
SGMP_DB_GEOMASHUP_DATA_CACHE_TIME
SGMP_INITIAL_WARNING

on lines 753, 754 and 755 of the plugin’s function.php.

A bit of debugging revealed that definitions for these constants have been removed from the /data/plugin.constants.json file in the migration from CGMP to SGMP.

On activation, the sgmp_on_activate_hook() function is updating (initialising) options referenced by these constants, generating the errors.

It appears that SGMP_INITIAL_WARNING is not used anywhere in the plugin (nor was it used in CGMP) and its initialisation in sgmp_on_activate_hook() should be removed.

The other two constants are used together in 10 other places in the functions.php file, so I think it would be prudent to put their definitions back in the /data/plugin.constants.json file until the reason for their removal has been more thoroughly considered.

Tony

Hi
thanks for your research. I have fixed the warnings in git, but haven’t release a new version.

The simplest change would be to apply the following patch to data/plugin.constants.json:

@@ -1,9 +1,11 @@
 [ {
     "SGMP_DB_POST_COUNT" : "sgmp_total_published_posts",
     "SGMP_DB_PUBLISHED_POST_MARKERS" : "sgmp_published_post_markers",
-       "SGMP_DB_PUBLISHED_POST_IDS" : "sgmp_published_post_ids",
-       "SGMP_DB_PUBLISHED_PAGE_IDS" : "sgmp_published_page_ids",
-       "SGMP_DB_PURGE_GEOMASHUP_CACHE" : "sgmp_purge_geomashup_cache",
+    "SGMP_DB_PUBLISHED_POST_IDS" : "sgmp_published_post_ids",
+    "SGMP_DB_PUBLISHED_PAGE_IDS" : "sgmp_published_page_ids",
+    "SGMP_DB_PURGE_GEOMASHUP_CACHE" : "sgmp_purge_geomashup_cache",
+    "SGMP_DB_GEOMASHUP_DATA_CACHE" : "sgmp_geomashup_data_cache",
+    "SGMP_DB_GEOMASHUP_DATA_CACHE_TIME" : "sgmp_geomashup_data_cache_time",

     "SGMP_ALL_MAP_CACHED_CONSTANTS_PREFIX" : "sgmp_cache_",

I am still fighting with getting html descriptions to be possible, and will release when that is done.

Hope that helps.

In case you want to contribute, please go ahead and send me pull requests ??

Nobert

Thanks for that Norbert.

I had already added the missing constants to the .json file on local my development machine.

You can’t use html in the title attribute – you’ll need to make your own tooltip from an html element like a div.

Tony

Hi Tony

yeah, by now one cannot add HTML code in the description of a marker, but that is something I want to change, i.e. to allow both simple markdown and also html.

We’ll see

Norbert