populate index with custom query by views

Hi @anarchoi,

When you’re executing a custom query via the WP_Query class you don’t use the regular have_posts() function with it. You should be using something like $wp_query->have_posts() instead. See WP_Query – Standard Loop for more details.

Also, I recommend renaming your $wp_query variable to something else (eg. $query or $popular_query). $wp_query is a global variable used by WordPress itself, and you may be introducing some odd / unexpected bugs to your site by overwriting that global variable with your custom query.

Also, please use the CODE button when posting code on www.remarpro.com.

Hi, thanks for the reply

I edited my code but I still can’t get it to work ??

<?php
/*
Template Name: Popular Posts 
*/
?>

<?php get_header(); ?>

<?

$args = array(
	'posts_per_page' => '50',
	'meta_key'=>'wpp_get_views', 
	'orderby'=>'meta_value_num', 
	'order'=>'DESC'
			   );
$my_query = new WP_Query( $args );

?>
<div class="wrapper section medium-padding">

	<?php
	$paged = (get_query_var('paged')) ? get_query_var('paged') : 1;
	$total_post_count = wp_count_posts();
	$published_post_count = $total_post_count->publish;
	$total_pages = ceil( $published_post_count / $posts_per_page );
	
	if ( "1" < $paged ) : ?>
	
		<div class="page-title section-inner">
		
			<h5><?php printf( __('Page %s of %s', 'baskerville'), $paged, $my_query->max_num_pages ); ?></h5>
			
		</div>
		
		<div class="clear"></div>
	
	<?php endif; ?>

	<div class="content section-inner">
																		                    
		<?php if ($my_query->have_posts()) : ?>
		
			<div class="posts" id="Posts">
					
		    	<?php while ($my_query->have_posts()) : the_post(); ?>
		    	
		    		<div class="post-container">
		    	
						<div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
			    	
				    		<?php get_template_part( 'content', get_post_format() ); ?>
				    				    		
			    		</div> <!-- /post -->
		    		
		    		</div>
		    			        		            
		        <?php endwhile; ?>
	        	                    
			<?php endif; ?>
			
		</div> <!-- /posts -->
		<div id='infinite-view'></div>	
	</div> <!-- /content -->
	
	<?php if ( $my_query->max_num_pages > 1 ) : ?>
		
		<div class="archive-nav section-inner">
					
			<?php echo get_next_posts_link( '&laquo; ' . __('Older posts', 'baskerville')); ?>
						
			<?php echo get_previous_posts_link( __('Newer posts', 'baskerville') . ' &raquo;'); ?>
			
			<div class="clear"></div>
			
		</div> <!-- /post-nav archive-nav -->
	
	<?php endif; ?>
			
	<div class="clear"></div>

</div> <!-- /wrapper -->

	              	        
<?php get_footer(); ?>

If you used the exact same code as the one from here then the problem is that you’re using the wrong meta key name with your query ??

You have:

'meta_key'=>'wpp_get_views',

and it should be:

'meta_key'=>'views_total',

or:

'meta_key'=>'views_daily',

or:

'meta_key'=>'views_weekly',

or:

'meta_key'=>'views_monthly',

I just tried that but it makes the CPU load spike to 100% until it completely crashes MySQL ?? maybe because I have around 100k posts

Hmm maybe not related to the 100k posts because if I try this query instead:

$args = array(
    "post_type" => "post",
    "orderby" => "post__in",
    "order" => "ASC",
    "posts_per_page" => "50",
    "post__in" => array(344941, 344944, 344951)
);

it also crashes MySQL and returns a timeout error in the browser although it’s just 3 posts… I’m confused. Is there an endless loop in my code or something?

<?php
/*
Template Name: Popular Posts 
*/
?>

<?php get_header(); ?>

<?

// $args = array(
// 	'posts_per_page' => '50',
// 	'meta_key'=>'views_total', 
// 	'orderby'=>'meta_value_num', 
// 	'order'=>'DESC'
// 			   );

$args = array(
    "post_type" => "post",
    "orderby" => "post__in",
    "order" => "ASC",
    "posts_per_page" => "50",
    "post__in" => array(344941, 344944, 344951)
);

$my_query = new WP_Query( $args );

?>
<div class="wrapper section medium-padding">

	<?php
	$paged = (get_query_var('paged')) ? get_query_var('paged') : 1;
	$total_post_count = wp_count_posts();
	$published_post_count = $total_post_count->publish;
	$total_pages = ceil( $published_post_count / $posts_per_page );
	
	if ( "1" < $paged ) : ?>
	
		<div class="page-title section-inner">
		
			<h5><?php printf( __('Page %s of %s', 'baskerville'), $paged, $my_query->max_num_pages ); ?></h5>
			
		</div>
		
		<div class="clear"></div>
	
	<?php endif; ?>

	<div class="content section-inner">
																		                    
		<?php if ($my_query->have_posts()) : ?>
		
			<div class="posts" id="Posts">
					
		    	<?php while ($my_query->have_posts()) : the_post(); ?>
		    	
		    		<div class="post-container">
		    	
						<div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
			    	
				    		<?php get_template_part( 'content', get_post_format() ); ?>
				    				    		
			    		</div> <!-- /post -->
		    		
		    		</div>
		    			        		            
		        <?php endwhile; ?>
	        	                    
			<?php endif; ?>
			
		</div> <!-- /posts -->
		<div id='infinite-view'></div>	
	</div> <!-- /content -->
	
	<?php if ( $my_query->max_num_pages > 1 ) : ?>
		
		<div class="archive-nav section-inner">
					
			<?php echo get_next_posts_link( '&laquo; ' . __('Older posts', 'baskerville')); ?>
						
			<?php echo get_previous_posts_link( __('Newer posts', 'baskerville') . ' &raquo;'); ?>
			
			<div class="clear"></div>
			
		</div> <!-- /post-nav archive-nav -->
	
	<?php endif; ?>
			
	<div class="clear"></div>

</div> <!-- /wrapper -->

	              	        
<?php get_footer(); ?>

edit: yep, it must be an error in the loop because if I remove everything after the query and only do a print_r($my_query) it executes in less than 1 second without any server load issues.

• This reply was modified 2 years, 11 months ago by Winston.