Pop-up can be closed inside an empty space

  • Resolved George

    (@giorgos93)


    1 year, 11 months ago

    Hi! I set your plugin’s pop-up window, and I put a button inside with the help of a shortcode (from a “MaxButtons” plugin). There is a span class with a container around this button (it has 100% width, I guess, and it was made by a plugin’s developers, not by me).

    So, I made settings to close popup either with a close (X) icon, or by clicking the button. However, from the left / right of the button, there is a space, that for some reason can close popup, if it’ll be clicked on. Here is a .gif with the problem: https://ibb.co/1qL2YD5

    Is there any way, how I can disable pop-up’s closing, if someone presses this empty space from the left / right?

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Support Kim L

    (@kimmyx)

    Hi @giorgos93,

    Do you have a link for us to check this popup?

    Based on your gif, it seems you have added the span class of the max button to the close popup shortcode, that’s why it’s closing when clicking the whole span.

    Please try targeting the button class instead.

    We’d love to check it though so if you can drop the link, that would be helpful!

    Thread Starter George

    (@giorgos93)

    Hi, @kimmyx , thanks for the answer!

    Atm I temporarily disabled popup because of that situation. I’ll notify you soon, when I’ll be able to turn it on again. And post a website link then.

    I have a screenshot of the PC popup’s needed piece of code: https://ibb.co/10HSWpw

    I rememeber, that I read your manual on how to close a popup by a button click. And tested several options for the code. And this one worked perfectly, except for the closing inside an empty space.

    What could be wrong with that code? The button is wrapped around in [popup_close] tag. And there is a “div” tag, “classes” and “extraclass”. And no span class for the button.

    Plugin Support Kim L

    (@kimmyx)

    Hi @giorgos93,

    This could be because of how the button is generated by the “MaxButtons” plugin.

    Can you try enclosing a regular button without using a plugin?

    [popup_close tag="button" classes="extra-button-class"]Close this popup[/popup_close]

    We’ll wait for your update.

    Maxbuttons dev here. The container span is a setting in the button editor, which you can disable there under the heading ‘container’.

    Bel

    (@belimperial)

    Hi @basszje

    Thanks for joining the thread for this input.

    Another thing to check is the class on the span that wraps the maxbutton.

    @giorgos93 can you move the pum-close popmake-close popmake-close pum-close pum-do-default inside the maxbutton span class?

    Please see: https://share.getcloudapp.com/RBuBOBZg

    Let us know how it goes.

    Thank you!

    Thread Starter George

    (@giorgos93)

    @basszje thanks for the advice! Unfortunately, it didn’t solve the problem. If I disable this container span, the button still can be closed from both sides. But I’ve found a solution!

    @belimperial thank you for the advice! It did help me to find the solution! Here is, what I did:

    I’ve created a new button. And added “popmake-close pum-close pum-do-default” class in MaxButton’s settings for it (in “Additional class” tab). Then I changed a Maxbutton’s ID in Popup Maker’s code, removed there the class “popmake-close pum-close pum-do-default”, and moved popup_close tag=”div” inside maxbutton’s tag (and removed it’s closing tag).

    Here is, how it looks like: https://ibb.co/JkfNXB5

    After that, button is not closed from sides anymore. Thanks!

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Pop-up can be closed inside an empty space’ is closed to new replies.