Plugin strips some characters out of affiliate link

  • Resolved PetrNovak

    (@petrnovak)


    4 years, 1 month ago

    Hi, I’ve noticed that plugin strips out some characters out from an affiliate link. It may lead to a problems with registering the link within affiliate program.

    As far as I know, the problem is with the following characters: {}

    • Example of a destination URL: […]&utm_source={affiliate_id}&[…]
    • This is how ThirstyAffiliate strips it: […]%26utm_source%3Daffiliate_id%26[…]
    • This is the correct version: […]%26utm_source%3D%7Baffiliate_id%7D%26[…]

    Stripping these characters out is a bad thing. We lost $$$ because of that. Rather, these characters should be encoded.

    Please consided fixing this, thank you.

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Caseproof

    (@caseproof)

    Hi

    The URL is passed through the esc_url_raw function before it’s saved in the database, which is stripping these {} characters because they are unsafe for URLs.

    You can encode the {} characters in the URL &utm_source=%7Baffiliate_id%7D and they will be kept.

    You might want to check if you are supposed to replace {affiliate_id} with your own affiliate ID as it looks like a placeholder.

    Thread Starter PetrNovak

    (@petrnovak)

    Hi Caseproof, thank you for the reply.

    The thing is that affiliate links doesn’t work after this stripping. I am not able to replace {affiliate_id} as it is done on server-side.

    I think a lot of users lose money because of this edit – they might not even know about this feature. It would be better if plugin encoded those characters instead of stripping them, what do you think?

    Thanks ??

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Plugin strips some characters out of affiliate link’ is closed to new replies.