Viewing 4 replies - 16 through 19 (of 19 total)
  • Thread Starter dandv

    (@dandv)

    Hi guys,

    I need to look into this in more detail when I have a bit more time, but for now I can say that,

    • the initial issue, with the missing opening p tag, happend in the Pods editor
    • the issue with extra p/br tags inserted in script tags happened in the WordPress page editor

    In the meantime I looked at the code for wpautop (its use of variables like $pee and $tinkle didn’t impress me), and it appears that it tries to leave script tags alone. So there may be some interaction with another plugin. I don’t have an obvious possible culprit right now, because of the 8 plugins that are active, none should mess with the post content much: AddThis Follow Widget, Broken Link Checker, Dynamic Widgets, Google XML Sitemap, MailChimp Widget, Pods CMS Framework, and WP Slim Stat + its Dashboard widgets.

    For now I’ve just nixed wpautop by having it just return $pee;. I never liked the idea of my input being second-guessed anyway.

    Plugin Author MarcusPope

    (@marcuspope)

    @dandv – Definitely let me know what you find, but with my plugin installed and activated wpautop should not be running. As another recommendation I suggest that you also disable the visual tab or the javascript version of wpautop. Othwerise it will still corrupt your markup if you click on the visual tab.

    I’m sorry my plugin didn’t work for you. It is quite strange considering your plugin installation. I’m assuming you’re using the latest version of wordpress?

    And yeah, the $pee var names are a bit unprofessional, but the codebase is full of code that doesn’t meet WP coding standards, well past the tipping point to bother.

    If you get a chance to email me the full code sample you were trying to use I’d definitely like to add it to my test cases.

    Thanks,
    Marcus

    Plugin Author MarcusPope

    (@marcuspope)

    @scott – I see the problem with execution sequence, but I’m not 100% sure if that’s a problem when wp_editor isn’t updated with a new class. I’m not sure that it’s fine either, so I’ll just need to run some code and debug the callstack.

    If the demo video’s for pods will get me to a point where I can setup a configuration described by @dandv then I’ll watch that and get a test case going. If you think a step by step guide from you would be a faster route then something like that, even if just scratch notes, would be great.

    I’m going to add this to my personal support site as a todo and probably manage it there as new feature development. Due to my daughter’s arrival date being in a couple weeks this might not be resolved as quickly as I would prefer.

    I’ll do what I can to either open up those hooks or just change my patching execution sequence to be much later in the chain. The later would have a better impact on third party plugins where authors aren’t necessarily willing or able to update their plugins.

    Thanks,
    Marcus

    I’m available on gchat and skype if you need me, info is posted at https://scottkclark.com/

    Otherwise feel free to e-mail me and we’ll go through it.

Viewing 4 replies - 16 through 19 (of 19 total)
  • The topic ‘[Plugin: Preserved HTML Editor Markup] FAQ? Does this plugin actually disable wpautop?’ is closed to new replies.