[Plugin: Post Snippets] snippets containing javascript fail

Hi,

If you can provide me with the javascript snippet that breaks the plugin, I’d be happy to take a look at it and see what I can do about it.

Cheers,
Johan

Thanks for responding. I can’t preview this post, so I am going to break the script tags with -x- in this post, just in case. Here goes:

`
<span class="tglsz"><scr-x-ipt language="JavaScript" type="text/javascript"><!--
imgRsz({wid},{ht},{pgpc},"{imgurl}","imghalfleft","onclick='tglsz(this.name)\;'");
dw(" " + this.name + " ");
//--></scr-x-ipt>
</span>
`

@johan,
By the way, I should have mentioned in the original post that this occurs in the HTML editor. I have TinyMCE disabled.

Thanks for the example code. I tested with it here and couldn’t get it to break the editor like it happens for you, but it worked fine.

The plugin encodes <> for snippets to be inserted directly in the editor until they are inserted to make sure that the browser isn’t tempted to execute them and cause any conflicts.
ie. <script> is transformed to \x3Cscript\x3E while waiting to be used, so javascript should be safe and work to use in snippets to be inserted directly in posts.

So if it fails, I speculate that it could perhaps be a browser issue. What browser are you encountering this problem with?

I’m on Linux, with Google Chrome 12.0, and Firefox 5.0. Same issue in both. Using Ubuntu 10.04.

I did notice the following error in Firefox’s Error Console for all wp-admin pages:

Error: missing ; before statement
Source File: https://burgwinkel.com/blog/wp-admin/tools.php
Line: 41, Column: 218
Source Code:
var postsnippet_3 = "\x3Cspan class=\"tglsz\"\x3E\x3Cscript type=\"text/javascript\"\x3E\nimgRsz({wid},{ht},{pgpc},\"{imgurl}\",\"{cssclass}\",\"\\n onmouseout='return nd();' \\n onmouseover='return overlib(\\"some text, commas okay, no apostrophes, quotes, or double-quotes\\",CAPTION,\\"click to toggle size\\");' \\n onclick='tglsz(this.name);'\\n \"); dw(\" \" + this.name + \" \");\n\x3C/script\x3E\n\x3C/span\x3E";

And this from the Error Console when I push the Post Snippets button in the HTML editor:

Error: edOpenPostSnippets is not defined
Source File: https://burgwinkel.com/blog/wp-admin/post.php?post=1074&action=edit
Line: 1

I have just remembered this has always been an issue for me with Post Snippets. I installed it ages ago, probably shortly after its first release, and it would work with plain text, or even HTML markup, I think. But since it would never work if I had script snippets recorded, I just never used it. It is a very useful plugin, and hopefully I can figure this out.

Thanks for the extra info.
I actually have an old laptop sitting around with Ubuntu 10.04 installed. ??
I’ll do some testing on that machine and see if I can replicate the problem. Much easier to start digging if I can see the error here as well.

Cheers,
Johan

Scratch the above. I actually managed to replicate your problem on my win machine now. Nothing to do with the os/browser.
I messed around with the js code you had posted above, and I noticed that on some places the escaping of quotes are \\” instead of \”.

And as soon as I entered a \” directly into a snippet it confuses the JS engine as it then believes the string has ended prematurely. In your snippet, are the snippets written with escaping, ie. \”, or has this happened on the way?