Plugin Not working in wordpress 3.9

+1

On lines 167 and 168 of custom-permalinks.php, there are references to a function called mysql_real_escape_string. This function does not seem to be supported any more. I found simply removing the references seemed to work, though I cannot say it would work for other sites.

Original lines:

” ( LOWER(meta_value) = LEFT(LOWER(‘”.mysql_real_escape_string($request_noslash).”‘), LENGTH(meta_value)) OR “.
” LOWER(meta_value) = LEFT(LOWER(‘”.mysql_real_escape_string($request_noslash.”/”).”‘), LENGTH(meta_value)) ) “.

My changes:

” ( LOWER(meta_value) = LEFT(LOWER(‘”.$request_noslash.”‘), LENGTH(meta_value)) OR “.
” LOWER(meta_value) = LEFT(LOWER(‘”.$request_noslash.”/’), LENGTH(meta_value)) ) “.

Remember to make backups of any files you modify BEFORE you modify.

Hope this helps!

nice fix, its working now, thanks

i added this function and then replaced mysql_real_escape_string with ms_escape_string

function ms_escape_string($data) {
        if ( !isset($data) or empty($data) ) return '';
        if ( is_numeric($data) ) return $data;

        $non_displayables = array(
            '/%0[0-8bcef]/',            // url encoded 00-08, 11, 12, 14, 15
            '/%1[0-9a-f]/',             // url encoded 16-31
            '/[\x00-\x08]/',            // 00-08
            '/\x0b/',                   // 11
            '/\x0c/',                   // 12
            '/[\x0e-\x1f]/'             // 14-31
        );
        foreach ( $non_displayables as $regex )
            $data = preg_replace( $regex, '', $data );
        $data = str_replace("'", "''", $data );
        return $data;
    }

I actually decided to work within the framework of WP itself, and applied this (better) fix than my above fix. WordPress provides SQL sterilization natively if the right commands are use, so here it is, with no warranties:

In the WP plugins directory, in custom-permalinks, in custom-permalinks.php find the following lines:

$sql = “SELECT $wpdb->posts.ID, $wpdb->postmeta.meta_value, $wpdb->posts.post_type FROM $wpdb->posts “.
“LEFT JOIN $wpdb->postmeta ON ($wpdb->posts.ID = $wpdb->postmeta.post_id) WHERE “.
” meta_key = ‘custom_permalink’ AND “.
” meta_value != ” AND “.
” ( LOWER(meta_value) = LEFT(LOWER(‘”.mysql_real_escape_string($request_noslash).”‘), LENGTH(meta_value)) OR “.
” LOWER(meta_value) = LEFT(LOWER(‘”.mysql_real_escape_string($request_noslash.”/”).”‘), LENGTH(meta_value)) ) “.
” AND post_status != ‘trash’ AND post_type != ‘nav_menu_item'”.
” ORDER BY LENGTH(meta_value) DESC, “.
” FIELD(post_status,’publish’,’private’,’draft’,’auto-draft’,’inherit’),”.
” FIELD(post_type,’post’,’page’),”.
“$wpdb->posts.ID ASC LIMIT 1”;

Replace them with:

$sql = $wpdb->prepare(“SELECT $wpdb->posts.ID, $wpdb->postmeta.meta_value, $wpdb->posts.post_type FROM $wpdb->posts “.
“LEFT JOIN $wpdb->postmeta ON ($wpdb->posts.ID = $wpdb->postmeta.post_id) WHERE “.
” meta_key = ‘custom_permalink’ AND “.
” meta_value != ” AND “.
” ( LOWER(meta_value) = LEFT(LOWER(‘%s’), LENGTH(meta_value)) OR “.
” LOWER(meta_value) = LEFT(LOWER(‘%s’), LENGTH(meta_value)) ) “.
” AND post_status != ‘trash’ AND post_type != ‘nav_menu_item'”.
” ORDER BY LENGTH(meta_value) DESC, “.
” FIELD(post_status,’publish’,’private’,’draft’,’auto-draft’,’inherit’),”.
” FIELD(post_type,’post’,’page’),”.
“$wpdb->posts.ID ASC LIMIT 1”,$request_noslash,$request_noslash . “/”);

This restored my permalinks to working order. As always, make a backup of the custom-permalinks.php file before modifying it in case something goes horribly wrong. Good luck!