Plugin no longer working – Cannot split date correctly, Error 30000

Hi Andi,

Apologies for the error you’re facing here.

This has been fixed recently but is yet to be pushed up to the repo. 2.1.0 will be deployed later this week along with some other fixes, so stay tuned – we’re working as quick as we can on this!

Thanks

Your error is here:

assets / front-end /js /main.js (main.min.js)

Line 85:

$('#' + st_object.id + '-cc-year').val( "20" + date_details[1] );

* You do not need to prefix the 20
* the 20 + string of date_details[1] which is probably an integer equates to undefined.

Solution

remove the spaces around the / and make sure it is a string

var date_details = $(this).val().toString().split('/');

Check the array length is > 1 to prevent undefined error on the second part of the array trying to populate the hidden page fields.

if(date_details.length > 1) {

remove the 20 and trim any white space so it reads…

$('#' + st_object.id + '-cc-year').val( date_details[1].trim() );

This is the whole fix in place.

$(document).on('change, keyup', '#' + st_object.id + '-card-expiry', function () {
		if ($(this).val().indexOf('/')) {
			///var date_details = $(this).val().split(' / ');
			var date_details = $(this).val().toString().split('/');

			if(date_details.length > 1) {				
				/// 29.01.2019 - Fixed
				$('#' + st_object.id + '-cc-month').val( date_details[0].trim() );
				///$('#' + st_object.id + '-cc-year').val( "20" + date_details[1] );
				
				$('#' + st_object.id + '-cc-year').val( date_details[1].trim() );

			}
		}
	});

Now this all works and checks out but the return post never updates the WC checkout so you are stuck on the same page.

Thanks

Andi

On a “side-note”, hoping that the developers of this plugin read this:

This plugin has caused our company significant disruption since we first encountered problems last year, nearly four months ago and probably way before that.

I ask you, the developers, to please test this plugin in the next release robustly. On mobile, desktop, and with other payment service providers enabled too, such as paypal and stripe.

We disabled the plugin, and no longer use it, which then means securetrading are not making as much money from us.

We’ll use it if it works, which currently, it does not.

ok also in this file…

classes / class-st-payment-gateway.php

in three instance around lines 531, 631, 901

$expiry_date[1] = '20' . $expiry_date[1];
the issue with this is that it expects the date input is going to be just the last 2 digits. ie 2021, 21.

my card data is saved in the rowser and returns the full date wgereas the paynent gateway mask is 2 digits or yy, however this gets overwritten and sends yyyy format.

so after i figured out that part of the issue is some lines of code prefixing 20 as in the centuary before the array part as in the class is expecting… i added this function.

public function prefix_year($date){
	    $pattern ='/^([0-9]{2})$/';
	    $date = preg_replace($pattern, '20$1', $date);
	    
	    return $date;
	}

thus function will check the length of a value and return the prefix if it is only 2 characters long, or the four digit date.

so all you have to do with those three lines is pass it to the filter method above.

///$expiry_date[1] = '20' . $expiry_date[1];
		$expiry_date[1] = $this->prefix_year($expiry_date[1]);

dont forget the js solution as well…then it all works… or should do.

thanks,

andi