[Plugin: Media Tags] Media Library inline fix

  • When adding/uploading media to a post/page, in the Media Library tab there’s an option to assign/remove tags in bulk from a group of checked images. That feature was not working. To make it work:

    media-tags\js\mediatags_bulk_common.js ~li 59

    if ((select_media_tags == "") && (media_tags_input == ""))
	{
		jQuery('#media-tags-error').html('<p>Please enter or select which Media Tags should be applied to the selected Media Items.</p>');
		jQuery('#media-tags-error').focus();
		return false;
	}
/* [alx359] redundant code. Tags not being updated in inline view because of this
	else
	{
		jQuery('#media-tags-error').html('<p></p>');
	}
*/

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Paul Menard

    (@pmenard)

    Actually I have to disagree. The code is not redundant. The else part of the code simply clears the $media-tags-error element on the popup.

    But I do see the issue. Was not aware this was not working. Thanks.

    Thread Starter alx359

    (@alx359)

    Sorry, not proper wording used. Error handling is not redundant, think just needed to be in other place down the code.

    Thank you so much, Paul, for the fixes of this great plugin!

    Plugin Author Paul Menard

    (@pmenard)

    No man! Thank you for all the bug fix code. I’ve been busy on client projects and have not really had a chance to do comprehensive review of bug reports or check coding I’v done in the past.

    Thread Starter alx359

    (@alx359)

    All the thank-you’s go to you, Paul. I’m just humbly trying to give something back for this great giving of yours! Your plugin is great work, especially the powerful bulk parts.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘[Plugin: Media Tags] Media Library inline fix’ is closed to new replies.