[Plugin: Google Map Shortcode] Plugin Broken in WP 3.3

Viewing 2 replies - 1 through 2 (of 2 total)

  • There seems to be a serious problem with quotes in the script.
    in the parameter “info” in the js on the page the attributes in the html uses single quotes. But then when it comes to url:s, suddenly the system forces double quotes. This of course causes a syntax error, which in turn breaks the map.

    Also, in the relevant option in the db, the attribute-quotes are escaped, which they aren’t when the thingie hits the page. somewhere someone, either the plugin or wp strips the escapes.

    This means it is not so simple as just switching places between singles and doubles, since the a-tag for the map contains script within the parameter which in turn contains single quotes…

    The ideal would probably be delimiting the parameter with single quotes, using double quotes for the attributes and then having the nested single quotes escaped.

    I hope this doesn’t sound like gibberish, because I’m a bit short on time when I write this. I thought a bit of input would be good though.

    replace the line 53 in functions.php with:

    $infodatadirty = gmshc_get_windowhtml($point);
$infodataclean = addslashes($infodatadirty);
$output .= "\"info\":\"".$infodataclean."\",\n";

    It could probably be done in one line, but I prefer this for readability

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘[Plugin: Google Map Shortcode] Plugin Broken in WP 3.3’ is closed to new replies.