[Plugin: Events Manager] Bug? Locations list always "eventful"

left joins should show locations with or without an event, pretty sure a bug like this was fixed a while ago (not caused by this, someone else pointed it out)

But it’s not showing all events, I’m sure of it. I echoed the $sql and ran the full statement in phpMyAdmin — I only got eventful locations. I took out the LEFT JOIN line and it showed all locations.

I had this same problem. I changed the SQL statement from:

//Create the SQL statement and execute
		$sql = "
			SELECT $fields FROM $locations_table
			LEFT JOIN $events_table ON {$locations_table}.location_id={$events_table}.location_id
			$where
			GROUP BY {$locations_table}.location_id
			$orderby_sql
			$limit $offset
		";

to

//Create the SQL statement and execute
		$sql = "
			SELECT $fields FROM $locations_table
			GROUP BY {$locations_table}.location_id
			$orderby_sql
			$limit $offset
		";

This breaks the “My Locations” functionality, but at least it fixes the ‘All Locations’ list to show all locations, not just the locations currently attached to an event.

I’d love to get the ‘My Locations’ functionality back, but the duplicate locations created by people because they couldn’t see the ghost locations were a bigger problem.

will revisit that and fix

tested this again, created a location directly, no event attached to it, and it appears everywhere.

again, I don’t think this is the cause (unless maybe you have an old mysql server version and it’s to do with that?) because left joins are meant to return all of the first table values whether there’s a corresponding row (e.g. events), only filtered by the where clause.

If this doesn’t work in the next update, try echoing the $sql and paste that without removing the join SQL