Please use proper hook

  • Lead developer of Redux here. The way you coded Redux is conflicting with others. Please change this line of code:
    add_action( 'admin_enqueue_scripts', 'ampforwp_add_admin_styling' );
    to this:
    add_action( 'redux/page/redux_builder_amp/enqueue', 'ampforwp_add_admin_styling' );

    This can be found in on line 25 of your ~/includes/features/functions.php file.

    Thank you.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Ahmed Kaludi

    (@ahmedkaludi)

    Thank you for your time to point out the code improvement required. We will create a ticket for this issue. It will be fixing in our future updates.

    Reference: https://github.com/ahmedkaludi/accelerated-mobile-pages/issues/4457

    Plugin Author Ahmed Kaludi

    (@ahmedkaludi)

    With the help of that hook, we are adding styles and scripts which we need outside the AMP redux options panel and if we need only for redux options then we use toplevel_page_amp_options and add only for AMP options panel as you can see in like number 36 – https://monosnap.com/file/EFUn93tqofrpTJKdOo2vaCYdMwBkJW

    So if we changed the hook as you suggested then our styles and scripts wont work out the redux which we needed.

    Can you please tell us exactly what issue you are facing so that we can find some way to fix it

    Thread Starter Dōvy Paukstys

    (@dovyp)

    Every other Redux panel has your code. You need to isolate and only call hooks for pages that are needed guys. ??

    Turn on the Sample Config for Redux and see your css file conflicting. It’s not good to add your CSS to every page of the admin. It’s not the best practice.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Please use proper hook’ is closed to new replies.