PHP compatibility & performance issue!

  • Resolved Xandro

    (@sudarshankotian)


    2 years, 5 months ago

    Hi, I was just testing PHP compatibility with PHP Compatibility Checker plugin and found that your plugin has some issues as below >

    FILE: /public_html/wp-content/plugins/disable-dashboard-for-woocommerce/includes/freemius/includes/sdk/FreemiusWordPress.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 330 | WARNING | Since PHP 7.0, functions inspecting arguments, like debug_backtrace(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter "$pUrl" was used, and possibly changed (by reference), on line 310.
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /public_html/wp-content/plugins/disable-dashboard-for-woocommerce/includes/freemius/includes/class-freemius.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 19534 | WARNING | Since PHP 7.0, functions inspecting arguments, like func_get_args(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter "$tag" was used, and possibly changed (by reference), on line 19532.
 19691 | WARNING | Since PHP 7.0, functions inspecting arguments, like func_get_args(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter "$tag" was used, and possibly changed (by reference), on line 19689.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /public_html/wp-content/plugins/disable-dashboard-for-woocommerce/includes/freemius/includes/class-fs-logger.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 43 | WARNING | Since PHP 7.0, functions inspecting arguments, like debug_backtrace(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter "$id" was used, and possibly changed (by reference), on line 41.
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

    Also, in wp hive it shows this plugin is taking too much memory usage i.e. > Average memory usage is 502.52 KB.

    I hope you will solve these issues in future updates.

    Thank you for this wonderful plugin.

    And are you planning to support this plugin for 8.1 PHP version?

Viewing 10 replies - 1 through 10 (of 10 total)

  • @sudarshankotian I would also like to know, I tested the same with the pro version and see the same results. Seems PHP 8 is really not ready for use sadly. )o;

    Thread Starter Xandro

    (@sudarshankotian)

    Thanks for the update @neikoloves in fact I tried this on php 7.4 ??

    Plugin Author Disable Bloat

    (@disablebloat)

    Hello @sudarshankotian and @neikoloves

    Thank you for using the plugin.

    PHP:

    The plugin is fully compatible with PHP 8.0 and 8.1. It has been fully tested with these PHP versions and you can be sure that there are no errors/warnings/notices caused by using PHP 8.X with our plugin. We are running PHP 8.1 in our test environment and I can assure you that you won’t expect any problems caused by the upgrade to PHP 8.X.

    In this case, PHP Compatibility Checker is reporting false positives, as the mentioned variables are not actually modified before the mentioned functions are called. You can read about the false positives in the PHP Compatibility Checker readme:

    Please note that linting code is not perfect. This plugin cannot detect unused code-paths that might be used for backwards compatibility, and thus might show false positives. We maintain a whitelist of plugins that can cause false positives. We are continuously working to ensure the checker provides the most accurate results possible.

    Memory usage:

    After implementing the license management system in the 3.0 version of the plugin, the plugin is using more memory during activation. During the activation process, the plugin is making necessary checks which can be more memory-consuming. We are currently investigating this issue and checking if the memory usage is getting lower after the activation. We will try to fix this issue after finishing the analysis process.

    Thread Starter Xandro

    (@sudarshankotian)

    Hi, @disablebloat thanks for the update. Good to know that, this plugin is Php 8.1 compatible. ??

    Plugin Author Disable Bloat

    (@disablebloat)

    Sure @sudarshankotian

    We will update the PHP code in the plugin so that the Checker won’t show any false positives in the future.

    @disablebloat @sudarshankotian It’s great to know this is only a false positive. The licencing system is just a mess, not an easy one to solve I guess. Seems to be buggy at best. Thanks for the updates guys.

    @disablebloat for me that is the error the plugin shows, I read your answers, just posting it here bcz it is might not be the same you saw before:
    version_compare(): Passing null to parameter #1 ($version1) of type string is deprecated

    wp-content/plugins/disable-dashboard-for-woocommerce/includes/functions/disable-bloat-functions_free.php:102
version_compare()
wp-content/plugins/disable-dashboard-for-woocommerce/includes/functions/disable-bloat-functions_free.php:102
Disable_WC_Bloat->includes()
wp-content/plugins/disable-dashboard-for-woocommerce/disable-dashboard-for-woocommerce.php:125
Disable_WC_Bloat->__construct()
wp-content/plugins/disable-dashboard-for-woocommerce/disable-dashboard-for-woocommerce.php:115
Disable_WC_Bloat::instance()
wp-content/plugins/disable-dashboard-for-woocommerce/disable-dashboard-for-woocommerce.php:194
disable_woocommerce_bloat()
wp-content/plugins/disable-dashboard-for-woocommerce/disable-dashboard-for-woocommerce.php:198

    @disablebloat and about the memory issue @sudarshankotian told us about? Tks!

    • This reply was modified 2 years, 4 months ago by diegpl.

    /wp-content/plugins/disable-dashboard-for-woocommerce/includes/functions/disable-bloat-functions_free.php

    I have commented line 102 “if” for now:
    if (version_compare($wc_version, ‘6.2.0’) < 0) {

    Plugin Author Disable Bloat

    (@disablebloat)

    @diegpl

    We already know about this warning and the fix is on its way. Please stay tuned for updates.

    At this moment we are not planning to switch to a different license system, so the memory usage will probably stay at the same level for now.

    Plugin Author Disable Bloat

    (@disablebloat)

    Dear @sudarshankotian and @diegpl

    Plugin version 3.1.0 has been released and it solves some memory-related issues. Now, the WP Hive report is not showing the memory usage notice.

Viewing 10 replies - 1 through 10 (of 10 total)
  • The topic ‘PHP compatibility & performance issue!’ is closed to new replies.