PHP 7 Compatability?

  • Resolved adz1111

    (@adz1111)


    7 years, 12 months ago

    Hi

    Just checking if the plugin (1.5.38) is PHP 7 compatible?

    Running a compatibility checker it reports 1 warning and 1 error for 2 of the plugin’s files:
    ================================================================
    FILE: /wp-content/plugins/woocommerce-pdf-invoices-packing-slips/lib/dompdf/include/page_cache.cls.php

    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE

    40 | WARNING | Method name “Page_Cache::__query” is discouraged; PHP has reserved all method names with a double underscore prefix for future use
    ================================================================
    FILE: /wp-content/plugins/woocommerce-pdf-invoices-packing-slips/lib/dompdf/include/table_frame_decorator.cls.php

    FOUND 1 ERROR AFFECTING 1 LINE

    181 | ERROR | Using ‘break’ outside of a loop or switch structure is invalid and will throw a fatal error since PHP 7.0
    ===============================================================

    Thanks

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Contributor Ewout

    (@pomegranate)

    Hi! Thanks for the heads up! The warning is harmless, and the error is a false positive, it’s actually in a while loop, but using short notation:

    
    while ( $frame = $frame->get_parent() )
      if ( $frame->is_table() )
        break;

    Note that this is part of a third party library, which I try to modify as little as possible.
    As far as I know the plugin is PHP7 compatible.

    Ewout

    • This reply was modified 7 years, 12 months ago by Ewout.
    Thread Starter adz1111

    (@adz1111)

    Ok great – thanks!

    Hi @adz1111

    I’m maintaining couple websites (Woocommerce, WPML, WooCommerce PDF Invoices & Packing Slips, …) on PHP7. I can confirm that this plugin is PHP 7 compatible. More info at https://github.com/wimg/PHPCompatibility/issues/292

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘PHP 7 Compatability?’ is closed to new replies.

Tags