PHP 7.3 Compatibility

  • Resolved johnny538

    (@johnny538)


    5 years, 11 months ago

    I’ve been using AO for a few months now without issues. I excluded a plugin dir in from JS/CSS optimization cause it wasn’t working otherwise.

    Yesterday I upgraded from PHP 7.0 to 7.3, and this specific plugin (WooCommerce POS) stopped working. The developer console is showing AO related errors.

    In fact, with JS optimization enabled, the plugin page (WooCommerce POS) is not working at all most of the time. And I just get a chrome error err_empty_response. 1 in 30 hits actually retrieves the page. And I still get those errors in the console.

    php error log only shows: php ah00052 exit signal segmentation fault (11). Which I get when the empty response is retrieved.

    I believe since the php upgrade the “Exclude … from optimization” function has stopped working.

    When I disable JS optimization entirely, the plugin works again.

    I have to mention I also upgraded to WP 5.0.2 (coming from pre v5) at the same time.

    Please see if you can reproduce.

    WP 5.0.2
    WC 3.5.3
    AO 2.4.4

    PHP7.3-fpm

    Other pagespeed tools I use: Redis Object Caching, WP Super Cache, mod_pagespeed (apache) (not using it for js/css related things, just images)

    Let me know if I can help with debugging.

Viewing 12 replies - 1 through 12 (of 12 total)
  • Plugin Author Optimizing Matters

    (@optimizingmatters)

    hmm .. maybe because of AO minifying un-minified excluded JS? can you try this code snippet?

    add_filter('autoptimize_filter_js_minify_excluded','__return_false');

    hope this helps,
    frank

    Thread Starter johnny538

    (@johnny538)

    That didn’t seem to help. The error in the console is:

    “The namespace must be a non-empty string.”

    Which appears 4x.

    However, I think the issue with the empty responses might be unrelated, cause I still get that with JS optimization disabled. I contacted the WP POS plugin developer as well regarding PHP 7.3 compatibility.

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    re. the console error; can you share your sites URL so I can have a look?

    Thread Starter johnny538

    (@johnny538)

    The page in question is on the backend. Unfortunately I can’t give admin access ??

    When I get home I’ll try to access the page through CLI with strace. Maybe I’ll discover more.

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    in that case; Autoptimize doesn’t optimize pages under /wp-admin/, so it’s very unlikely those errors are due to AO anyway ??

    Thread Starter johnny538

    (@johnny538)

    I guess technically it’s front-end. It’s just not actually visible there. The WooCommerce POS needs a user that’s either admin or as the ‘Cashier’ role. Opening a register happens initially in /wp-admin/ but then sends you to /point-of-sale/location/register-name/. So not in /wp-admin/. It’s just where you start it up. Sorry for the confusion.

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    I see. Well, you could try disabling the “also optimize for logged in users”-option?

    Thread Starter johnny538

    (@johnny538)

    Won’t that disable optimization for all user roles ? So including woocommerce customers who are logged in ?

    PS: The Dutch translation for ‘logged in’ is set to ‘aangelogde’ instead of ‘ingelogde’.

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    Won’t that disable optimization for all user roles ? So including woocommerce customers who are logged in ?

    no, only for users that have ‘edit_posts’ rights ??

    PS: The Dutch translation for ‘logged in’ is set to ‘aangelogde’ instead of ‘ingelogde’.

    Zal ik eens bekijken ??

    groeten uit Belgi?,
    frank

    Thread Starter johnny538

    (@johnny538)

    Sorry for wasting your time. It was a conflict with the WooCommerce POS (Piece of Shit) plugin.

    It also broke the /checkout/ page :s That’s when I noticed the errors regarding the checkout were related to the POS plugin.

    They persisted when I downgraded to PHP 7.0 and disappeared when I deactivated the POS plugin.

    I’m gonna upgrade to 7.3 again later tonight and see if everything still works.

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    thanks for the feedback Johnny538 ??

    Hi guys, just to clarify for anyone arriving by search .. this is an issue with WooCommerce Point of Sale from Code Canyon, not WooCommerce POS available on www.remarpro.com.

Viewing 12 replies - 1 through 12 (of 12 total)
  • The topic ‘PHP 7.3 Compatibility’ is closed to new replies.