PHP 7.3 Compatibility

  • Resolved macadk

    (@macadk)


    5 years, 3 months ago

    I recently ran the WP Engine PHP Checker and found that your plugin threw 11 errors:

    FILE: /home/ms101admin/public_html/wp-content/plugins/wp-reset/wp-reset.php
    ———————————————————————————–
    FOUND 1 ERROR AFFECTING 1 LINE
    ———————————————————————————–
    2604 | ERROR | Visibility for magic method __sleep must be public. Found: private
    ———————————————————————————–

    FILE: /home/ms101admin/public_html/wp-content/plugins/wp-reset/libs/dumper.php
    ————————————————————————————————————
    FOUND 10 ERRORS AFFECTING 10 LINES
    ————————————————————————————————————
    398 | ERROR | Extension ‘mysql_’ is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
    400 | ERROR | Extension ‘mysql_’ is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
    403 | ERROR | Extension ‘mysql_’ is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
    405 | ERROR | Extension ‘mysql_’ is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
    415 | ERROR | Extension ‘mysql_’ is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
    417 | ERROR | Extension ‘mysql_’ is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
    429 | ERROR | Extension ‘mysql_’ is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
    439 | ERROR | Extension ‘mysql_’ is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
    448 | ERROR | Extension ‘mysql_’ is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
    453 | ERROR | Extension ‘mysql_’ is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
    ————————————————————————————————————

    I am running WP 5.3.2 on Apache 2.4.41 with PHP 7.2. I want to move to PHP 7.3, but your plugin is currently holding me back.

    The page I need help with: [log in to see the link]

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author WebFactory

    (@webfactory)

    Hi,
    Thank you for letting us know. We’ll get those fixed in the next release, next week.

    Plugin Author WebFactory

    (@webfactory)

    Hi,

    I took a look at those errors and only the first one is a real error. The other 10 are false positives. Our dumper lib supports both mysql and mysqli lib and there’s no reason to remove support for mysql just to pass that test.

    Thread Starter macadk

    (@macadk)

    OK, so shall I notify the authors that your plugin is generating a false positive?

    Plugin Author WebFactory

    (@webfactory)

    Please do. I think they need to add a manual exception. Otherwise, it’ll always show up as problematic. At some point, we’ll remove the mysql support but even the WP core still supports both mysql and mysqli.

    Thread Starter macadk

    (@macadk)

    Done. I don’t know how good a job WPEngine is doing at maintaining their whitelist, as it doesn’t appear to have had an update in a while, but at least they know. I posted the issue on the plugin GitHub page.

    Plugin Author WebFactory

    (@webfactory)

    Thank you, Doug! Just found that thread on GitHub and left a comment ??

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘PHP 7.3 Compatibility’ is closed to new replies.