• Resolved Ray Gulick

    (@raygulick)


    The following warning is indicated when checking compatibility with PHP 7.2:

    FILE: /home/evostorm/public_html/luisakolker/wp-content/plugins/popup-maker/includes/pum-sdk/freemius/includes/fs-essential-functions.php
    ——————————————————————-
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ———————————————
    173 | WARNING | Function name “__fs” is discouraged; PHP has reserved all method names with a double underscore prefix for future use.
    —————————————————–

    Could you release an update that addresses this warning?

    The page I need help with: [log in to see the link]

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Daniel Iser

    (@danieliser)

    @raygulick You are fine & can ignore it for a few reasons:

    1. I work 100% on PHP latest stable at all times. So the plugin is developed on PHP 7.2+ currently.

    2. The scanner detects for global functions by scanning for function __*(, but doesn’t have the ability to determine if a function isn’t really a function but rather a method when its scanning a class method. Its technically a false positive.

    IE Global Function

    function __fs() {}

    Class Method

    class MyClass {
        private function __fs() {}
    }

    Not global at all ;).

    3. We don’t load that code any longer, since v1.7.29. It runs once to save a variable in the database letting us know if you previously opted in, then never runs again.

    Hope that helps. If your issue is resolved please take a moment to rate and review the plugin or support.

    If you still need help please message us directly at https://wppopupmaker.com/support/.

    Thread Starter Ray Gulick

    (@raygulick)

    Thanks for your response @danieliser. I figured this was the case, but need to assure my clients of Popup Maker’s compatibility for their PHP upgrade.

    I already gave you guys 5 stars a couple years ago.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘PHP 7.2 warning’ is closed to new replies.