php 7.2 compatibility

I think most of these can be traced to a typo on line 225 that ends up wrapping an entire conditional in count(), instead of just one term. The issue with unlink(), however, looks like it might be related to the configuration of your install… are you using s3 offload, or a similar plugin to host your image files in a non-standard location?

I’m looking into that typo now.

• This reply was modified 7 years ago by wpsmartcrop.

I just pushed an update that should fix many of these warnings, however the unlink warning seems to be legitimate.

Let me know if this helps

I’m using bedrock
https://roots.io/bedrock/
which uses app instead of wp-content. Is it possible to make it compatible? what should I notice from these unlink warnings? more or less everything seems to work

Edit: no testing myself but a colleague is telling me last update not showing warnings anymore ??

• This reply was modified 7 years ago by ecommonist.
• This reply was modified 7 years ago by ecommonist.

Bedrock shouldn’t cause a problem. smartcrop can handle changes to the wp-content path.

That unlink warning happens when smartcrop tries to regenerate one of the sized versions of an image, and the thumbnail it is replacing doesn’t exist. it doesn’t prevent the plugin from working, but it can be indicative that images aren’t being generated in the right spot. It can also just mean that a thumbnail size was added after that image was uploaded.

In any event, it sounds like everything is working for you now, so I’m gonna mark this as resolved. Let me know if anything else pops up.

Hi!

keeping receiving some warnings related to image dimensions.

2018/03/05 10:11:31 [error] 1145#1145: *165 FastCGI sent in stderr: “PHP message: PHP Warning: imagecreatetruecolor(): Invalid image dimensions in /vagrant/web/wp/wp-includes/media.php on line 2836
PHP message: PHP Warning: imagecopyresampled() expects parameter 1 to be resource, boolean given in /vagrant/web/wp/wp-includes/class-wp-image-editor-gd.php on line 183” while reading response header from upstream

can you tell me what you are doing when this error is thrown? it sounds like a situation where a nonexistent image is accidentally sent to media.php, but not sure where that would happen in smartcrop.

I activate plugin. Upload a picture, enable smart crop and done. Not even moving focus point.