Persistent Banner asking for review

  • Resolved rerm

    (@rermis)


    5 years, 1 month ago

    After the last release, any page on WordPress options (/wp-admin/options-general.php) displays a persistent banner asking for a review of the MailChimp program. This notice has a button to be dismissed, but it appears on the next page load.

    Per WordPress guideline #11: “Plugins should not hijack the admin dashboard.
    Users prefer and expect plugins to feel like part of WordPress. Constant nags and overwhelming the admin dashboard with unnecessary alerts detract from this experience.

    Upgrade prompts, notices, alerts, and the like must be limited in scope and used sparingly, be that contextually or only on the plugin’s setting page. Site wide notices or embedded dashboard widgets must be dismissible or self-dismiss when resolved.”

    The page I need help with: [log in to see the link]

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Support khungate

    (@khungate)

    Hi @rermis, thank you for reaching out. The banner should degrade gracefully after clicking the close icon. Also, it should only be showing on the Mailchimp plugin after a successful sync is done.

    Are you saying that the banner appears elsewhere? And is it displaying after you close it out?

    Please note, the best way to reach us is over at the GitHub plugin page. From there, you can receive direct responses from the development team, log new issues, download the latest version and track existing support tickets.

    Thread Starter rerm

    (@rermis)

    Hi khungate,

    Yes, that is correct, after a sync is complete, the banner persists and appears on all subsequent page loads under /options-general.php settings. It appears on all pages under WordPress options/settings, whereas plugin guidelines encourage isolating plugin-specific banners to the plugin’s settings page only (not all of the WordPress option/settings pages). Text of the banner follows with account data retracted:

    Your store is synced with Mailchimp!

    We’ve successfully synced XXX orders to your Audience XXX, that’s awesome!

    Could you please do us a favor and leave the plugin a 5-star rating on www.remarpro.com? It helps our community know that we’re working hard to make it better each day.

    Leave a Review

    Plugin Support khungate

    (@khungate)

    @rermis, I’m pasting @ryanhungate’s response around banner troubleshooting as we’re supposed to reserve reviews for plugin feedback:

    As for the banner issue, you’re right that’s not the way it’s supposed to be working, but we’ve not been able to simulate this type of behavior that you’re describing. I would first ask if you’ve got any caching plugins, or possibly anything that would prevent you from deleting an option using the delete_option functions? Could it possibly be a permissions issue? Just throwing things against the wall for you to look at.

    If you could go to your wp-options page and search for mailchimp-woocommerce-sync.initial_sync please set that to 0 and see if your problem goes away. We’re a little confused as to why this isn’t being cleared out.

    Thread Starter rerm

    (@rermis)

    Thanks Ryan,

    I ruled out caching and permissions. If I manually flip mailchimp-woocommerce-sync.initial_sync to zero the problem resolves. Should the action of dismissing the banner be setting the mailchimp-woocommerce-sync.initial_sync to zero?

    Plugin Author ryanhungate

    (@ryanhungate)

    @rermis yes, to be specific, in the admin code, we’re adding a trigger that should be using the ajaxurl of the admin to execute an action:

    wp_ajax_mailchimp_woocommerce_remove_review_banner

    which calls:

    mailchimp_woocommerce_remove_review_banner inside the plugin admin code. This is where we’re deleting the option.

    The only thing that pops out at me is maybe for some reason your browser might be blocking this request for some reason, or possibly the admin-ajax file is having trouble completing this request when you try to dismiss it.

    Even though we’re not able to replicate it, we do know that different environments can produce different results. We’ll do our best to figure out how this happened to you ( and anyone else for that matter ).

    • This reply was modified 5 years, 1 month ago by ryanhungate.
    Plugin Support khungate

    (@khungate)

    @rermis we just wanted to let you know we pushed up a patch (v2.3.2) to remove that persistent banner review per your feedback. Again, we apologize for any hassle, it was something we only saw in certain hosting environments. We appreciate your patience, let us know if there’s anything else we can do for you.

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Persistent Banner asking for review’ is closed to new replies.