Perfecty Push Notifications Widgets

  • Resolved stkuhn

    (@stkuhn)


    3 years, 6 months ago

    Sorry,

    two more questions about the Perfecty Push Notifications widgets:

    1. A click on “perfecty-push-settings-open” always opens “perfecty-push-settings-form”. That’s good for subscribed users, that want to change the settings. But for new users it would be more convenient to directly open “perfecty-push-dialog-box” for subscription. Could you change this?

    2. In “perfecty-push-settings-open” wifget admins can’t style the icon-color cause you use a base64 encoded svg. If you directly integrate the svg-code into the html, than admins could also style the icon-color via CSS. I just patched the “perfecty-push-sdk.min.js” and integrated the svg-code. It works fine (check it on my private website). Could you change that image-handling?

    Thanks for your good work & support …
    Stefan

    PS: If you want I can help you style the widgets …

    The page I need help with: [log in to see the link]

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Rowinson Gallego

    (@rwngallego)

    Hi @stkuhn, sure!

    I’ve created this ticket: https://github.com/rwngallego/perfecty-push-wp/issues/39

    The Pull Request is ready with your suggested changes, for the moment I’ve based part of the CSS styles to the example you’ve provided. Are you OK if we use them partially? Also, is the SVG the same as the one from font-awesome or where did you take it? I need to mention where we got it in the license notes.

    Of course, if you want to help out with the styling that would be great!

    Thread Starter stkuhn

    (@stkuhn)

    Hi @rwngallego,

    sure you can take my code partially (or even complete) – it’s a give and take! For your information: the icon I use is more compact than yours and is from https://fonts.google.com/icons?icon.query=bell. It would be also a good idea to change clickable “divs” to semantically more correct “buttons”.

    greets
    Stefan

    Plugin Author Rowinson Gallego

    (@rwngallego)

    Hi @stkuhn that sounds very cool, thank you! In regards to the font, we will go back to the font awesome SVG icon because of the license. I’ll update the PR and probably release it soon ??

    Plugin Author Rowinson Gallego

    (@rwngallego)

    Hi @stkuhn we’ve updated the PR (https://github.com/rwngallego/perfecty-push-wp/pull/40) to use a button instead of a div, if there are any additional changes please let us know ??

    Plugin Author Rowinson Gallego

    (@rwngallego)

    This has been released in the v1.1.4 version

    Thread Starter stkuhn

    (@stkuhn)

    Great job …

    and almost perfect! There is only one error left in googles lighthouse check: “Buttons do not have an accessible name!” You can fix this with title="Web Push Einstellungen" aria-label="Web Push Einstellungen" attributes in the button-tag. Would also be great if admins could change that text in the backend (or simply use the “Bell title”) …

    To meet googles material design guidelines for floating action buttons you could also increase the size of the #perfecty-push-settings-open svg from 48x48px to 56x56px (just recognized that different size-advice a few days ago).

    And for code-optimization (and also to ignore existing font awesome stylings) you should delete the following unused attributes from the svg-code:

    data-prefix="fas" data-icon="bell" class="svg-inline--fa fa-bell fa-w-14"

    Last but not least there is a less critical warning in w3c validator: “The language attribute on the script element is obsolete. You can safely omit it.” To fix this just delete language=javascript from <script language=javascript> when inlining the settings in the html-code.

    Thanks a lot again and greets …
    Stefan

    Plugin Author Rowinson Gallego

    (@rwngallego)

    Hi @stkuhn thanks for your message! This has been included in this PR: https://github.com/rwngallego/perfecty-push-wp/pull/45

    Plugin Author Rowinson Gallego

    (@rwngallego)

    This has been released in v1.1.5. Thanks @stkuhn for your contribution!

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘Perfecty Push Notifications Widgets’ is closed to new replies.