PayPal Standard BROKEN when rounding amounts

(@mikejolley)

Can you enable logging and send the log for one of these transactions? The gateway uses:

$paypal_args['tax_cart'] = $order->get_total_tax();

And total_tax is always rounded to 2, so should be rounded up as well.

Thread Starter

(@bfarnam)

You are referring to the PayPal transaction log, correct? Here it is:

Thread Starter

(@bfarnam)

One other thought:

I upgraded to the newest WC last night and the error still persists.

I looked at:

$paypal_args['tax_cart'] = $order->get_total_tax();

and changed it to:

$paypal_args['tax_cart'] = round($order->get_total_tax(),2);

and the error still persisted.

I then TURNED OFF (UNCHECKED) Apply Tax To Shipping and I was unable to duplicate the error. This does not mean that the error was not there, it just means that I did not hit the magic numbers that duplicate the error.

I also looked closely at the orders and was able to add the amounts in the order view and see how the truncating or rounding is causing the error.

Now you mentioned that total tax is always rounded to 2. Are you using the round function? Apparently the round function produces inconsistent results across different platforms and this “feature” is well documented.

The workaround is to create your own function such as:

<?php
function mround($number, $precision=0) { 

    $precision = ($precision == 0 ? 1 : $precision);
    $pow = pow(10, $precision); 

    $ceil = ceil($number * $pow)/$pow;
    $floor = floor($number * $pow)/$pow; 

    $pow = pow(10, $precision+1); 

    $diffCeil     = $pow*($ceil-$number);
    $diffFloor     = $pow*($number-$floor)+($number < 0 ? -1 : 1); 

    if($diffCeil >= $diffFloor) return $floor;
    else return $ceil;
}  

echo mround(4.725, 2); // Yes 4.73
?>

Credits go to PHP.net for this code snipplet.

Plugin Contributor

(@mikejolley)

The log shows:

tax 1.28
item1 14.42
shipping 1

Which adds to 16.70. How does this differ to the order itself?

Thread Starter

(@bfarnam)

The log, which is generated by the plugin, has the wrong amount, which is why PayPal pays the wrong amount.

The Order amount is $ 16.71 . . . NOT $16.70.

In fact, $order->get_total() returns 16.71, NOT 16.70.

Plugin Contributor

(@mikejolley)

I know that.. I’m asking if the other amounts differ from the order itself.

Are you using the option “Round tax at subtotal level, instead of rounding per line”?

Thread Starter

(@bfarnam)

https://cryptohampster.com/wp-content/uploads/2014/02/cart.png

Hello, Yes, sorry for the confusion.

Yes the amounts differ from the order itself as viewed in the order details or even in the shopping cart.

Also I just tested it, it does not matter if “Round tax at subtotal level, instead of rounding per line” is checked (on) or unchecked (off).

https://cryptohampster.com/wp-content/uploads/2014/02/checkout.png

https://cryptohampster.com/wp-content/uploads/2014/02/paypal.png

Plugin Contributor

(@mikejolley)

Screenshot your tax rates for me too.

Thread Starter

(@bfarnam)

https://cryptohampster.com/wp-content/uploads/2014/02/tax1.png

https://cryptohampster.com/wp-content/uploads/2014/02/tax2.png

Thread Starter

(@bfarnam)

I do not have reduced rate or zero rate tax

Thread Starter

(@bfarnam)

I don’t know if this helps, but I did some more digging . . .

I changed line 366 and added a log entry under neath:

$paypal_args['tax_cart'] = $order->get_total_tax();
$this->log->add( 'paypal', 'Tax Cart '. $paypal_args['tax_cart'] . ' Tax Order ' . $order->get_total_tax() );

The log now shows:

02-15-2014 @ 15:30:51 - Tax Cart 1.28 Tax Order 1.28

And this is different from the cart . . . see above pic.

So PayPal is doing what it is supposed to do and paying what it is being told to pay by the plugin. The plugin is disconnected somewhere and not coming up with the same amounts as show in the cart . . .

Thread Starter

(@bfarnam)

@mikejolley, Have we had any luck on this?

Plugin Contributor

(@mikejolley)

https://github.com/woothemes/woocommerce/commit/f35c3708bbe54876fed979dabcc217efedd23f0d

Thread Starter

(@bfarnam)