Pagination form vs Forms

  • Resolved brechtp

    (@brechtp)


    6 years, 7 months ago

    I’m curious as to why the pagination uses a different event category than the submissions. Data would be much cleaner if instead of using the lowercase single ‘form’ for pagination you used the same “Forms” that is applied to all the other actions.

    Is there a reason this was done this way?

    I’d like to see these unified under “Forms” to clean up reporting

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Ronald Huereca

    (@ronalfy)

    @brechtp,

    It’s mostly there because of backwards compatibility. When I inherited the plugin, the default was Forms and Submission, which can be changed per feed.

    There are two options

    1. You can rename the feed to use form and submission to match pagination.
    2. The second, more advanced option is to use gform_pagination_event_action and gform_pagination_event_category and modify those to match your current goal.

    Thread Starter brechtp

    (@brechtp)

    Thanks so much for your reply!

    It looks like we could change
    $event_category = apply_filters( 'gform_pagination_event_category', 'form', $form, $source_page_number, $current_page_number );

    to

    $event_category = apply_filters( 'gform_pagination_event_category', 'Forms', $form, $source_page_number, $current_page_number );

    Am I wading off track with that?

    This is in GFGAET_Pagination.php

    • This reply was modified 6 years, 7 months ago by brechtp.
    Plugin Author Ronald Huereca

    (@ronalfy)

    You don’t want to edit the plugin file because an update will remove your custom code.

    I’ve created a gist for you that you’ll want to place in functions.php in your theme or in a site-specific plugin.

    Thread Starter brechtp

    (@brechtp)

    WOW What service! ??????????

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Pagination form vs Forms’ is closed to new replies.