• Hello. I have just been hired lately to maintain a site that uses your plugin. The owner is asking me to fix a problem. He says the “notes” section on the packing slip no longer has proper line breaks and is appearing with the text all run together which is making it hard for the team when they’re preparing the orders. This is a new problem that just recently occurred… apparently, it had been working fine until now. I’m not sure what may have caused this or how to fix it. Can you help?

Viewing 13 replies - 1 through 13 (of 13 total)
  • Plugin Contributor Yordan Soares

    (@yordansoares)

    Hi @eliyahna,

    Could you please share a screenshot of the packing slip notes, so we can try to understand what could be happening?

    You can use imgbb.com to upload the image, and then share its link here.
    See: Uploading Images to?www.remarpro.com

    Thread Starter Eliyahna

    (@eliyahna)

    Sure @yordansoares here you are https://ibb.co/0YWvhj1

    • This reply was modified 6 months, 3 weeks ago by Eliyahna.
    Plugin Contributor Yordan Soares

    (@yordansoares)

    Thanks for sending that screenshot, @eliyahna:

    However, this does not seem to be the packing slip, but the order details. Could you please take a screenshot of the notes on the PDF packing slip instead?

    Thread Starter Eliyahna

    (@eliyahna)

    Hi @yordansoares They are all looking this way. The invoice too. Here’s the packing slip: https://ibb.co/GkR4T0Y

    Plugin Contributor dwpriv

    (@dwpriv)

    @eliyahna thanks for the screenshot

    The notes look to be ordered. Could you show us what it’s supposed to/used to look like, please?

    Thread Starter Eliyahna

    (@eliyahna)

    I was a bit confused too @dwpriv Okay here are the files / samples the owner just sent over:

    https://ibb.co/3WgDkxT
    https://ibb.co/N3wsbQb
    https://ibb.co/NY52xkW

    Plugin Contributor dwpriv

    (@dwpriv)

    What version of our plugin are you running? My notes appear like this

    https://ibb.co/vXfh9MS
    https://ibb.co/bRTmCbM

    Thread Starter Eliyahna

    (@eliyahna)

    Thank you @dwpriv – it is Version 3.8.2

    Plugin Contributor dwpriv

    (@dwpriv)

    Thanks for the information @eliyahna

    I think we’ve found the issue. The <p> tag is not allowed in our sanitize method here, and so it is being stripped from the HTML. We’ve added the tag so that it can be printed and the fix will be a part of our next release.

    Thread Starter Eliyahna

    (@eliyahna)

    @dwpriv Thanks so much. Site owner asked… Any idea when that will be?

    Plugin Contributor dwpriv

    (@dwpriv)

    It’s possible we may release an update on Monday, though this may not be certain. However, if you’d like to test the beta on a staging site, you can download the plugin here

    Samuel

    (@aelmsu)

    We have a similar issue with version 3.8.2, but when we use double line breaks to create paragraphs in our customer notes, they’re converted to <br><br> by WordPress, not <p>.

    Example: The raw HTML of the customer note is

    A<br><br>
    B<br>
    C<br><br>
    D<br>
    E

    On the order view in WooCommerce, the customer note is rendered correctly as

    A

    B
    C

    D
    E

    but on the PDF invoice and PDF packing slip, the customer note is now rendered incorrectly as

    AB
    CD
    E

    which looks as if <br><br> is not replaced correctly with a double line break in the PDF.

    This has worked in previous versions of the plugin, so I hope you’ll be able to fix this issue. We are currently unable to send invoices because the missing line breaks lead to confusing or even faulty information on our invoices.

    Samuel

    (@aelmsu)

    Addendum to my previous post:

    I debugged get_shipping_notes(). The original value of $shipping_notes from my example above is

    <p>A</p>
    <p>B<br />
    C</p>
    <p>D<br />
    E</p>

    (apparently WordPress converts double line breaks into <p> elements followed by a <br> element), and after wpo_wcpdf_sanitize_html_content(), $shipping_notes is

    AB<br>
    CD<br>
    E

    So it’s the <p> that is stripped from the note, after all, and I assume @dwpriv’s pull request will fix this issue.

Viewing 13 replies - 1 through 13 (of 13 total)
  • The topic ‘packing slip notes’ is closed to new replies.