version_compare(): Passing null to parameter #2

A simple workaround, to avoid the deprecated null, is to add

return ''

At the end of the version_compare() function. But I don’t know if that hides in that function.

Hi @peter8nss ,

Thank you for reaching out.

The Event Aggregator service is not a plugin but it comes bundled with The Events Calendar plugin. The deprecation notice is most likely coming from the use of PHP 8.3, as The Events Calendar is not yet fully compatible with PHP 8.2 and higher (see PHP 8.2 compatibility and support).

However, our team is aware of these deprecation notices and is proactively addressing these through our routine release of updates (see PHP 8.x: Understanding what the Deprecation notices mean). For now, I recommend suppressing these notices by re-configuring your PHP error logging level (see PHP Logging Basics), which your WebHost can further assist you with.

As a “service”, event aggregator won’t be in the list of “plugins” returned by get_plugin_file. Hence, my concern that the problem in the code is more than just a deprecation issue.

ps: Your PHP 8.x: Understanding what the Deprecation notices mean) states “However, if you are using wp_debug for development purposes and encounter any issues that stop the code from executing and providing the expected result, we encourage you to contact our support team“.

Hi @peter8nss ,

Thank you for your message.

Apparently, in my tests, the deprecation notice only appears when using PHP 8.1 and above, when used with PHP 7.4, the notice does not appear (reference: Migration to PHP 8.1 – how to fix Deprecated Passing null to parameter error – rename build in functions).

Are you saying you are developing the site and this notice is blocking you from completing certain tasks or preventing the import function from completing as expected?

My site runs with WP_DEBUG off but, because my site involves a significant amount of PHP, I have a separate development environment with WP_DEBUG on. That way I pick up faults in my own code before they get released. It also means I pick up issues in plugins (and core WordPress). I report these to help with their open source development.

I have recently been upgrading my site to a more recent version of PHP – as PHP8.2 goes out of active support in just over a months time https://www.php.net/supported-versions.php, hence spotting this (and other) issues.

This does not block my development environment from running – the import function still completes. For me it is just annoying, but please be aware that deprecated features often indicate some misconception in coding. In this case I think Tribe__PUE__Checker::get_installed_version may always be returning null so not really doing what its name would imply. That is perhaps what your developers might care to look at.

I agree this is low priority, but it would be nice to have a Internal Bug Ticket Reference linked to it so I can spot in the changelog.

Hi @peter8nss ,

Thank you for your message and the explanation.

A bug report (below) has already been raised on this one. Thanks for all the details. I will definitely pass it along to our developers.

I am unable to provide an exact date or time estimate for when this bug will be fixed, but you’ll be notified when there are any updates.

If you do have other concerns or issues you need help with, please create another thread, as it helps us track different issues.

—

Internal Bug Ticket Reference: TEC-5086

Hi @peter8nss

We prioritize bugs by taking into consideration the number of users impacted as well as how the bug impacts one’s ability to run an event/sell tickets. I don’t have a specific timeline as to when this issue will be resolved, but trust that our team is aware. Our team communicates updates and bug fixes in our newsletter and via our changelog.

I’m happy to help if any other questions are coming up around this topic, otherwise I’ll go ahead and close this ticket.

Thanks again for reporting this issue and for using The Events Calendar! Have a great day.

—

Internal Bug Ticket Reference: TEC-5086