Outdated 3rd party issue

  • Resolved nextendnorbert

    (@nextendnorbert)


    3 years, 1 month ago

    Hi,

    In your plugin, you’re using this 3rd party library.
    https://github.com/dixso/custombox
    which uses an outdated version of the es6-promise package.
    https://www.npmjs.com/package/es6-promise
    So this es6-promise package should be updated, as it can conflict with other plugins that use promise.

    I opened an Issue on the library’s GitHub page, so it would be fixed there, and I’m also contacting you about it because it would be great if you could make the fix as well.

    I think that would be a good solution if you would make a new build with the updated es6-promise package and update your plugin using this new code.`

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Contributor Ketan Patel

    (@patelketan)

    Hi @nextendnorbert

    Thanks for reaching out to us.

    Yes, we are using Custombox Modal Dialog. I am not aware about the es6-promise package in this.

    Popup Anything on Click plugin includes custombox.min.js and custombox.legacy.min.js

    Can you please elaborate this a little more and let me know why we should add this es6-promise.js in our plugin?

    Thanks in advance.

    Thread Starter nextendnorbert

    (@nextendnorbert)

    Hi @patelketan!

    Sorry, for the misunderstanding. The es6-promise.js was used to build the third-party module, you can see their package.json file.
    https://github.com/dixso/custombox/blob/master/package.json
    just the es6-promise.js is outdated and because of this when someone use your plugin with other plugin which includes promise functions it makes a conflict.

    So what I suggest is to clone their repository, update their package.json file, and run a build, then change the old custombox.legacy.min.js to the new, builded one. That’s what I did on my test site and for me, this solved the problem.

    Plugin Contributor Ketan Patel

    (@patelketan)

    Hello,

    Thanks for your advice. We will check your suggestion.

    Thanks,

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Outdated 3rd party issue’ is closed to new replies.