Out of stock class is removed when variation is selected

  • Resolved platoche56

    (@platoche56)


    2 years ago

    Hi,

    Thanks for the plugin. It works great except for one single annoyance. thwvsf-public.js removes the out_of_stock class when a variation becomes selected.

    As the variation is out of stock, this should really not happen as I feel the default behaviour should be that at any point in time this class represents whether or not it is in stock.

    I checked the plugin code and was able to tweak it by altering the function disable_out_of_stock_variation_multiple. Shall it be implemented in the free version of the plugin ?

    BR,

    A

    • This topic was modified 2 years ago by platoche56.
Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author ThemeHigh

    (@themehigh)

    We have checked on our local environment and are not able to recreate the issue you are facing.

    Your issue needs a detailed check. Can you please raise a ticket through our website? We hope our technical team will be able to help you.

    Thank you!

    • This reply was modified 2 years ago by ThemeHigh.
    Thread Starter platoche56

    (@platoche56)

    For example see here.

    https://www.gossuin.com/product/turtleneck-gaston-01/?attribute_pa_color=brasilian-green

    As you will when you select an out of stock size for the grren jumper if you inspect its class the out of stock class is removed. Based on your code, this is what we expect. I am simply disputing this is the right way of implementing this.

    Plugin Author ThemeHigh

    (@themehigh)

    We believe that you would like to make the out stock variations clickable.

    If so, unfortunately, this feature is not available in the current version of our plugin.

    We will be adding this feature in the future version of the plugin.

    Thank you!

    Thread Starter platoche56

    (@platoche56)

    Not at all. By the way this is already the case. OOS variations are clickable.

    For example all green garments are OOS. Yet the M is selectible (fine by me) but the out of stock class has been removed. This is what the JS code has been designed to do but that is a bug for me.

    Now if we inspect the HTML we notice that the out_of_stock class has been removed for the M size button.

    In fact if I select a different size.

    The M becomes greyed out and cross as expected. The class out_of_stock is also back.

    Now let us take another example, this time variation only happens oon size, there are no other available colors.

    https://www.gossuin.com/product/shirt-alpha-01/

    Here the out_of_class is not removed and everything works as expected. Yet the size is selected.

    So to sum up when there is only one variation it works fine, when there are multiple in does not and remove too “eagerly” the out_of_stock class.

    This is noty really a feature, in both cases it shouyld keep the out_of_stock class which would enable us to style as we see fit.

    Plugin Author ThemeHigh

    (@themehigh)

    Can you please raise a ticket through our website? We hope our technical team will be able to help you.

    Thank you!

    Plugin Author ThemeHigh

    (@themehigh)

    Since we haven’t heard back from you, we hope your issue is resolved.

    We are going to mark this thread as resolved.

    Thank you!

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Out of stock class is removed when variation is selected’ is closed to new replies.