Order ID vs Order Number

  • Resolved ttimbul

    (@ttimbul)


    2 years, 10 months ago

    This plugin is not compatible with plugins that modify the order number.
    WooCommerce by default uses non-sequential order IDs based on the default wordpress database sequence, however, many users (myself included) prefer some form of sequential order numbers, such as provided by Sequential Order Numbers Pro.

    You should really be calling $order->get_order_number() instead of `$order->get_id().

    Even better, to preserve backwards compatibility, you should add another shortcode/placeholder for {ORDER_NUMBER}. Very easy one liner in woocommerce_sendinblue.php around line 768:
    '{ORDER_NUMBER}' => $order->get_order_number(),

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Support alice888

    (@alice888)

    Hello @ttimbul,

    Thanks for your feedback here.

    The order ID is generalised to suit the majority of clients, for whom the value must be present in the string in order to display in transactional attributes and in the order_completed payload.

    There are no current plans to change the structure.

    Thanks again and please revert with further questions!
    Alice

    Thread Starter ttimbul

    (@ttimbul)

    Hence my suggestion of adding another placeholder, so existing users don’t suddenly find their emails breaking. But in our case we have the email subject (drawn in from what Woocommerce generates) different from {ORDER_ID} that is inserted in the template.

    Why are you rejecting this out of hand? If you lack manpower, I’m happy to contribute code.

    Obviously I can edit the plugin, but any changes I make would just disappear if you bring out any update. Or are you saying you won’t, because you think it’s “finished”? Then good luck to you, I’d better start looking for another email/marketing platform…

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Order ID vs Order Number’ is closed to new replies.