option is not showing in menus

@redrov Menus(Plugin) are not working with Impreza theme.

@sahilseta – Were you able to narrow it to the theme? If you send me a copy via our contact form and I can try to determine if there is a specific reason this is occuring.

@danieliser I am using Zephyr theme which is made by the same author as Impreza, seems a theme conflict…
Your contact form doesn’t allow to add files – where else can I send you a copy?

@tuempelkoenig Try the support form for Popup Maker (https://wppopupmaker.com/support/)

Did you report it to the theme author? If so what was there response? Update coming?

As soon as we can duplicate this we can either patch on our end or definitively put this to rest as something that theme authors are simply gonna have to patch to resolve properly.

Happy to help either way.

Just sent you a copy of the theme and posted in the theme author’s support forum…

? Hello,

Unfortunately, this plugin isn’t natively supported by Zephyr theme. Let us know what the authors says, probably we can create some workaround if they provide more details about the compatibility issue.“

@tuempelkoenig I’m using the impreza theme which is made by the same company. I’m wondering if a lot of other people are using this theme and it’s causing a problem?

@lenny1975, @tuempelkoenig – Hmm, as soon as I get a copy of the current version of their theme I can better asses why it wouldn’t be compatible. The thing is prior to WP 5.4, this may have sounded more reasonable. But as of WP 5.4, core now supports adding fields there by default. Should be even more compatible now than before.

Hopefully quick fix once I see it.

Ok, great thank you @danieliser I’m presuming you don’t need me/us to send you anything?

Hi Daniel, I have the same issue with my theme. It is called Samba (https://themeforest.net/item/samba-colored-wordpress-theme/5691055). Is it possible to send you a zip of the theme so you could check what is wrong? How can I reach you?

I’m also experiencing issues with the options not displaying. No errors are showing in the dev tools console though. Is there an update pending? Or any way of identifying what’s stopping this working… it’s very frustrating!

@tuempelkoenig, @sahilseta, @lenny1975 – Got it. Ok so those with the Zephyr/Imprezza, the theme itself is not the issue, but the UpSolution Core (us-core) plugin that must be installed with it.

Specifically they are doing the one scenario I didn’t outline before, they are overloading the WP core nav menu renderer (“Walker”) and not outputting the required call to do_action( 'wp_nav_menu_item_custom_fields', $item_id, $item, $depth, $args ); that core and the walker we use does. This is where we render our fields, and so do other plugins like Popup Maker, If Menus, Nav Menu Roles etc. So currently none of these plugins would render fields either.

Commenting out the following line that registers their custom admin nav menu walker fixes it: wp-content/plugins/us-core/admin/functions/nav-menu-edit.php:21

This is what they need to do long term: see Solution #2.

For examples of how we and many other plugins that are all compatible together do it see below.

Potential temporary workaround would be to unhook their walker with the following in your functions.php when you need to edit User Menu settings, then comment it out when not needing to edit it:

remove_filter( 'wp_edit_nav_menu_walker', 'us_edit_nav_menu_walker' );

Not ideal but it works

Examples of compatible methods of adding fields

User Menus
– https://github.com/JunglePlugins/User-Menus/blob/develop/includes/classes/admin/menu-editor.php#L22-L24
– https://github.com/JunglePlugins/User-Menus/blob/develop/includes/classes/admin/menu-editor.php#L33-L53
– https://github.com/JunglePlugins/User-Menus/blob/develop/includes/classes/walker/nav-menu-edit-custom-fields.php

Popup Maker (500k+ sites)
– https://github.com/PopupMaker/Popup-Maker/blob/master/includes/modules/menus.php
– https://github.com/PopupMaker/Popup-Maker/blob/master/includes/modules/menus/class-nav-menu-edit-custom-fields.php.

—

For everyone else, so far it has 100% been theme/theme related plugins causing this for similar reasons to those above. Seems many devs never realized that they were doing things in an incompatible way or missed the WP core release notes.

• This reply was modified 4 years, 6 months ago by Daniel Iser. Reason: Added temporary workaround
• This reply was modified 4 years, 6 months ago by Daniel Iser. Reason: Added temporary workaround

Thank you @danieliser I have submitted this ticked to the support teams at UpSolution https://help.us-themes.com/impreza/tickets/41516/

I’ll let you know what they say.

Thanks, too! Posted it this morning as well and they seem to be working on a fix.