Open Slide Link In New Window

  • Resolved rootoftheproblem

    (@rootoftheproblem)


    7 years, 1 month ago

    Open Slide Link In New Window = NO or YES, opens the slide’s “full screen” link in a new window no matter how it set.

    Hosting environment – Linux

    WordPress Version – 4.9.2

    PHP Version – 7.0

    Site URL where the error occurred – Offline lab environment/pre-prod

    Active Theme – Venture

    List of active plugin if possible – OK… so that would be a very long list

    Error messages in detail. – No error, just a functional config setting that does not function.

    Picture of error message if possible – https://6signs.com/Screen%20Shot%202018-01-17%20at%208.41.09%20AM.png

    Last thing you did right before the site blew up – Site did not blow up.

    • This topic was modified 7 years, 1 month ago by rootoftheproblem. Reason: added specifics
Viewing 4 replies - 1 through 4 (of 4 total)

  • I’m getting the same thing, and having a dig around, the problem seems to be in carousel-slider\templates\public\hero-banner-slider.php on the line…

    $_link_target = ! empty( $slide['link_target'] ) && in_array( $slide['link_target'],
 array( '_self', '_blank' ) ) ? esc_url( $slide['link_target'] ) : '_self';

    The function “esc_url” should be “esc_attr”, as its an attribute that being sanitised. The result is that the target is ending up as “https://_self”, presumably the browser defaults to opening in a new tab as it’s invalid.

    • This reply was modified 7 years, 1 month ago by eccles42.
    • This reply was modified 7 years, 1 month ago by eccles42.
    • This reply was modified 7 years, 1 month ago by eccles42. Reason: typos!
    Plugin Author Sayful Islam

    (@sayful)

    Thank you @eccles42 for your bug report. I fixed it just update your plugin to version 1.8.4

    Thanks again

    Thread Starter rootoftheproblem

    (@rootoftheproblem)

    Thanks, Sayful!

    Thanks, Sayful. And Thanks for this plugin, I couldn’t find one that did quite what I had in mind until I found yours.

    Andy

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Open Slide Link In New Window’ is closed to new replies.