Omit all unnecasary styles

Hi,

thanks for your question and sorry for the trouble!

I see what you mean, and I can think of several solutions or workarounds here.
(Adding such an option is not really one of them, as that would imply the need for two separate CSS files, which is not a good idea, given that the vast majority of users will not need this.)

First idea: Why don’t you simply use TablePress for all of your tables and then adjust the “Custom CSS” as necessary?
Second idea: You could extract the relevant CSS for the sorting from TablePress’ default.css and add that your theme’s style.css. Then, turn off the inclusion of TablePress’s default CSS with this added line in your theme’s functions.php:

add_filter( 'tablepress_use_default_css', '__return_false' );

Third idea: Just adjust the TablePress styling with “Custom CSS”, so that it resembles your theme’s CSS. Most likely, you’ll just need to copy that CSS and prepend it with the .tablepress CSS class. This works similarly to adjusting the colors (for example the background color of the header row, that you are looking for). Examples for this are also included in the TablePress FAQ, at https://tablepress.org/faq/ e.g. in the answer to the question “How can I change the background color of the table head row?”.

Regards,
Tobias

Hallo, thank you for your answer.

First off: At least the third idea is a valid workaround, as you don’t have to touch the theme files (I wouldn’t suggest that because of upgrade compatibility of the theme).

Still I have to vouch for an option in the settings. You can deliver the CSS on a conditional (full or just minimal markup) which wouldn’t increase server load and queries. Of course the current full blown markup would be standard and in the options, the user could turn that off.

I’ll try with option three for now and will report back.

Okay, just to let you know: Trying to adapt the style via the Custom CSS isn’t really feasible.

For example. My theme uses

tbody tr td {
	border-bottom: 1px dashed;
	border-color: #999;
}

But tablepress uses

.tablepress tbody td {
        border-top: 1px solid #dddddd;
}

So I have to set border-top to none and border bottom the way I like it.

Basically, I’d need to do something like a reset. It would be much easier to just have an option in table press to disable their markup.

Especially, if you ever switch theme, or the theme changes its table markup.

I’d be happy, if you could reconsider the option.f

Hi,

thanks for your feedback!

Yes, option three would require some sort of reset as you mention it, although that should be very small in most cases.

Due to that, and for easier code, I think, then the best approach should actually be option two. Adding that one line to either the functions.php of a child theme of the actual theme (or even better: to a small new plugin) will be that “reset” that you mention. You would then just have to extract the relevant code for the JS functions and copy those into the “Custom CSS”.

If you put the code into the functions.php of a child theme, the update problem would be eliminated (that’s what child theme are there for). Also, the argument with switching the theme or the theme changing markup is not really valid, as removing that one line will then automatically give your tables the TablePress default styling again, so that everything will still look good.

And an option really is no alternative: For the vast majority of users, there’s just no need for it (you are the first one to ask for this ?? ). Also, doing this would have a performance penalty: This would require two HTTP requests to two CSS files. Additionally, another option (as a checkbox) would even clutter the user interface even more, making it harder for inexperienced users to understand all the options and settings. Less options is better here, as that’s the philosophy that WordPress follows, too (Decisions, Not Options).

I understand that this would be an easy solution for you, but for the majority of people it would bring no benefit and even make things slightly worse.
So, option two should then be your way to go, as that would have the reset and the usage of the filter to turn off the default CSS would be your option.

Regards,
Tobias

Hello,

I get your point. I decided to build a plugin, that archives the functionality, I want. I’ll publish it in the plugin directory, once it is ready, and I adhere the coding styles (first plugin).

Thank you for your help.

Hi,

yes, a custom plugin sounds like a good idea here then!
Now, instead of putting it in the plugin directory, where probably nobody will find it, how about putting it on the TablePress website? As you might have seen, there are already several “TablePress Extensions” on the website, and if you send me your plugin, I’ll add it there as well (and I could maybe give you advise on the code, if you want).

Regards,
Tobias