og:url does not point to canonical URL

Ah, hadn’t thought of that. ?? The problem is that section is used for a variety of pages, including indexes, categories, etc. So here’s what I went with:

if ( is_singular() ) $og['og:url'] = get_permalink( $post->ID );
else $og['og:url'] = $this->get_current_url();

function get_current_url() {
    $url = empty( $_SERVER['HTTPS'] ) ? 'https://' : 'https://';
    $url .= $_SERVER["SERVER_NAME"] .  $_SERVER["REQUEST_URI"];
    // remove the query string
    if ( strpos( $url, "?") !== false )
        $url = reset( explode( '?', $url ) );
    return $url;
}

Try out the latest DEV version and let me know if things work better. ??

js.

Great! But removing the entire query string could be dangerous if friendly URL are not set, right? Something like /?p=123 would be converted to /

This removes only Google tracking parameters. It could be interesting to remove other parameters like pk_campaign and pk_kwd (Piwik campaign tracking), other advertising systems, etc.

$og['og:url'] = preg_replace('/[\?&](utm_source|utm_medium|utm_campaign|utm_term|gclid)=([^&]+)/i', '', $og['og:url']);

I think /?p=123 would also mean that is_singular() === true…

But just in case, I made the function a little more flexible, as you suggested…

function get_current_url( $strip_query = 'notrack' ) {

      $url = empty( $_SERVER['HTTPS'] ) ? 'https://' : 'https://';
      $url .= $_SERVER["SERVER_NAME"] .  $_SERVER["REQUEST_URI"];

      switch ( $strip_query ) {
        case 'noquery' :
          if ( strpos( $url, '?' ) !== false )
            $url = reset( explode( '?', $url ) );
          break;
        case 'notrack' :
          $url = preg_replace( '/([\?&])(utm_source|utm_medium|utm_campaign|utm_term|gclid|pk_campaign|pk_kwd)=[^&]*&?/i', '$1', $url );
          break;
      }

Thanks,

js.