Odd off canvas behaviour after update

hey there,

Yes sir you are correct. I just noticed this on my site, ThemeAwesome.com – I have (or had) the off-canvas menu set to show mobile. I went to my site on my phone and the menu did not show up.

Thanks for bringing this to my attention. Greatly appreciate it.

Found the issue and corrected it. Pushing out a new update shortly. This is from the CAHNGELOG.txt:

Switched code in content-off_canvas.php on line 59 from wpforge_topbar_mobile_display to wpforge_mobile_display - this was causing the off-canvas menu not to appear when "Use Off-Canvas for Mobile?" was set to yes.

I believe I was going to rename wpforge_mobile_display to wpforge_topbar_mobile_display for some reason but never did and left it there and pushed out the update.

My fault entirely for not being more attentive to what I am doing. Again, I appreciate you bringing this to my attention.

• This reply was modified 7 years, 9 months ago by ThemeAWESOME.
• This reply was modified 7 years, 9 months ago by ThemeAWESOME.

Thanks for the rapid response and solution. Once again, great work!!

You are very welcome and thank you ??

Hi Again,

I think I’ve found a similar, if different issue with the top-bar. If top bar right is selected, it shows in the customizer, but not in the front end? In firebug there seems to be two top-bar-left divs, which I’m guessing is causing the issue. I’m actually trying to float everything center as I have done in the past by adding
.top-bar-left {
float: none;
margin: auto;
}
Which is sadly having no effect, I can give it a fixed margin in px, but not an auto margin. Apologies if I should have started a new thread or if its a how to beyond the support policy.

Thanks

Dave

Hey there,

hmmmmm, I see what you mean and I see why its happening. The default setting for Top of Browser Scroll and Top of Browser - Fixed is Links to the right however in content-nav.php you will see that it is set for the left (look at lines 46 through 50 and also lines 76 through 80), they look like this:

<?php if( get_theme_mod( 'wpforge_link_position','left') == 'left') { ?>
<div class="top-bar-left">
<?php } else { ?>
<div class="top-bar-right">
<?php } // end if ?>

when in fact they should be like this:

<?php if( get_theme_mod( 'wpforge_link_position') == 'right') { ?>
<div class="top-bar-right">
<?php } else { ?>
<div class="top-bar-left">
<?php } // end if ?>

If you can open up content-nav.php and go to line 46 through 50 and 76 through 80 and replace whats there with what I added above. It should work properly after that.

I’ll make the correction on my end and push it out with the next update (6.3.1.1) shortly.

Please let me know if that works for you as it is working on my end.

Thanks for bringing this up.

P.S. Yes trying to float everything center and it not having any affect is beyond the out of box support. You are correct, it falls into the “How to category”…my apologies.

Thanks Again,

I had an odd issue with the left top bar selected, showing an additional div, not sure if its my end and resolved when right seleted.

Cheers

Dave

It’s not an odd issue amigo. If you look at the html there are two top-bar-left in the top-bar, the reason for this is because one of them holds the top-bar-title – I haven’t moved it to to the actual <div class="top-bar-title"></div> just yet, but I will do that for the next release.

Any other “odd behavior” you have noticed?