Objects not matched / samedomain mistakenly masked

  • Resolved eikebaran

    (@eikebaran)


    4 years, 2 months ago

    Hi!

    First of all thanks for your Plugin – gets the job done ??

    I noticed a small bug:

    When you use object-embeds, these by specification (https://www.w3schools.com/tags/tag_object.asp) do not have a “src”-attribute but use the “data”-attribute for defining the embed-Url.

    On the other hand Embed privacys get_single_overlay()-Method in class-embed-privacy.php only processes the src-attribute, which wont work on the object as no provider-pattern can be matched on that empty src. This also causes any samedomain-objects to be masked as default and showing the privacy overlay for them.

    Possible solution:
    Add in Line 473, class-embed-privacy.php:

    if ($tag == 'object'){
	$embed_attr='data';
}else{
	$embed_attr='src';
}

    And also in the method get_single_overlay() replace all further occurences of

    $element->getAttribute( 'src' )

    by

    $element->getAttribute( $embed_attr )

    Seems to work so far.

    • This topic was modified 4 years, 2 months ago by eikebaran.
Viewing 7 replies - 1 through 7 (of 7 total)
Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘Objects not matched / samedomain mistakenly masked’ is closed to new replies.