Number of arguments for hook tribe_events_after_html

  • Resolved peter8nss

    (@peter8nss)


    6 months, 2 weeks ago

    Hook tribe_events_after_html says it takes two arguments but it is called in two places in the code with different number of arguments:

    Advanced_Display get_after_events_html - apply_filter with 2 arguments
    general.php tribe_events_after_html - apply_filter with 1 argument

    Because in one case it is called with 1 argument it is not possible to do an add_filter that expects 2 arguments as when called with one argument a PHP error will be generated.

    Should both cases of this filter have 1 argument to reflect the v1 design, leaving hooktribe_events_views_v2_view_after_events_html for the cases where 2 arguments are needed.

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Support tristan083

    (@tristan083)

    Hi @peter8nss ,

    Thank you for bringing this to our attention.

    Just to be clear, are you saying that the get_after_events_html (with two arguments) should be removed from the \wp-content\plugins\the-events-calendar\src\Tribe\Views\V2\Template\Settings\Advanced_Display.php file?

    Thread Starter peter8nss

    (@peter8nss)

    Not removed. Just the second argument. So it would be:

    /**
      * Filter imported from V1 of Views, kept since there was no requirement to
      * remove the backwards compatibility here.
    ...
     */
    $after = apply_filters( 'tribe_events_after_html', $after ); // Second argument removed.

    ...

    $after = apply_filters( 'tribe_events_views_v2_view_after_events_html', $after, $view );
    Plugin Support tristan083

    (@tristan083)

    Hi @peter8nss ,

    Thank you for your message and the clarification.

    I have logged an internal bug report about this with our product engineering team.

    Thank you for your patience and bringing this to our attention.

    —-

    Internal Bug Ticket Reference: TECTRIA-376

    Plugin Support Darian

    (@d0153)

    Hi @peter8nss

    We prioritize bugs by taking into consideration the number of users impacted as well as how the bug impacts one’s ability to run an event/sell tickets. I don’t have a specific timeline as to when this issue will be resolved, but trust that our team is aware. Our team communicates updates and bug fixes in our newsletter and via our changelog.

    I’m happy to help if any other questions are coming up around this topic, otherwise I’ll go ahead and close this ticket.

    Thanks again for reporting this issue and for using The Events Calendar! Have a great day.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Number of arguments for hook tribe_events_after_html’ is closed to new replies.