• Resolved Marklcm

    (@marklcm)


    I’ve installed the plugin , added the words “Test Caption” in the metabox and updated the page.
    In options I added a different class name though no css as yet
    theme is a child of twentyseventeen.
    Could it be something to do with featured images in 2017 not being in ‘the-content’, rather the header?

    The page I need help with: [log in to see the link]

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author fesomia

    (@fesomia)

    Hi @marklcm, there was a problem identifying individual pages that has been corrected in the new version. Please update the plugin to 1.14

    Let us know if it works now. Thanks for reporting

    Thread Starter Marklcm

    (@marklcm)

    that fixed it.
    many thanks
    good luck with the plugin

    Thread Starter Marklcm

    (@marklcm)

    hmmm it seems I spoke a bit soon.
    the caption is displaying, but with the plugin activated there is a shift down away from the menu for the featured image.

    I removed the text from the caption and there is still a strip of background below the featured, visible as the background has a pale color, not usually seen, as well as the shift down in the featured image.

    I thought this would be a quick fix with a bit of css, but cannot fix..
    I can leave the plugin activated for a little if you are still about, but am expecting traffic in response to new post, so will have to disable it shortly.

    I will have a play with it on local version. perhaps you may be able to replicate it?

    Plugin Author fesomia

    (@fesomia)

    Well you’ll have to fix it in the theme, editing the template or the css, as the plugin it’s not supposed to change the styles of the container by itself. I’ve looked at your site and I think that it’s an easy css fix (unless you need the green background), give it a try:

    .single-featured-image-header figure.wp-caption{
    margin-top:0;
    }
    
    .single-featured-image-header {
        background-color: transparent;
        border-color: transparent;
    }
    
    • This reply was modified 6 years, 8 months ago by fesomia.
    • This reply was modified 6 years, 8 months ago by fesomia.
    Thread Starter Marklcm

    (@marklcm)

    yes, that does hide the problem.
    When I said “can’t fix the problem” I meant I could not resolve the problem with a bit of quick css.

    Twentyseventeen outputs the featured image in the header in this layout
    div -> img
    not the semantically correct div -> figure -> img etc your plugin outputs.

    For some reason the wrapping div in the header is constricting the height of the featured image. Add enough text to the caption for 2 lines and it constricts the image size further.

    Even without any caption content the plugin outputs the empty figure/figcaption tags, which the browser outputs as taking a bit of room and still constricts the size of the image a bit.

    I have other templates in the child theme eg for events which display the featured image in the content, not the header. There are no such problems there. Everything works as expected.

    Yes, this all points to it being theme (twentyseventeen) specific, which is pretty widely used. I will try to figure out why and where the theme applies a height constriction in the header.

    BTW positioning the caption over the image does not resolve the problem.

    • This reply was modified 6 years, 8 months ago by Marklcm. Reason: added note to bottom
    Plugin Author fesomia

    (@fesomia)

    Thanks again for your feedback.

    We’ve updated the plugin to correct that empty figcaption you mentioned. From now on, if there is no caption at all, no empty layers will appear.

    As for the other points, unfortunately it’s not really feasible to make changes to the plugin so it adapts better to a given theme, as there are countless of them. Sometimes there will not be other option than to fine tune the css or the theme’s template files (or the child) to accommodate it better

    • This reply was modified 6 years, 8 months ago by fesomia.
Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘not working’ is closed to new replies.