Not all shortcode attributes are used

Hi,

I see in your code that you allow for an attribute title to be set in the shortcode

$atts = extract( shortcode_atts(array(
	'number_of_products_in_row' => "",
	'posts_per_page' => get_option( CED_RVMV_PREFIX.'_wrvp_total_items_display'),
	'title'		=> get_option( CED_RVMV_PREFIX.'_wrvp_viewed_title' )
), $atts,'wrvp_recently_viewed_products' ) );

but never use the title anywhere, you just use the exact same code again to get the title option

<h2><?php if(get_option( CED_RVMV_PREFIX.'_wrvp_viewed_title', null)){ echo get_option( CED_RVMV_PREFIX.'_wrvp_viewed_title');} else { echo __('Recently viewed produts','recently-viewed-and-most-viewed-products');} ?></h2>

Also you have a typo in 'Recently viewed produts' (it should be 'Recently viewed products').
Besides that I would like to have an option to allow for recently viewed products to be in 'woocommerce_after_single_product' per default, because in my case I wanted it to only show in the sidebar.

Other than that, absolutely using your plugin more often, because you have the only good working plugin for recently viewed products (and I tried a loooot of plugins)!

Thanks!

• This topic was modified 8 years, 4 months ago by gidomanders.
• This topic was modified 8 years, 4 months ago by gidomanders.